feat(substrait): AggregateRel grouping_expressions support #13173
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
approved these changes
Oct 31, 2024
Contributor
alamb
left a comment
alamb
left a comment
There was a problem hiding this comment.
Looks good to me -- thank you @akoshchiy
@vbarua can you double check this as well?
Contributor
|
I can put this on my queue for next week. |
Contributor
|
I am going to merge this PR to keep the code flowing. If there are any additional issues found as part of @vbarua 's review we can address them as a follow on PR. Thanks again @akoshchiy and @vbarua |
3 tasks
vbarua
reviewed
Nov 6, 2024
Contributor
vbarua
left a comment
vbarua
left a comment
There was a problem hiding this comment.
This looks pretty reasonable to me 🙂
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #12957.
Rationale for this change
What changes are included in this PR?
Added support of
grouping_expressionsfield inAggregateRel. Deprecated support is still here - producer fills both fields, and consumer tries to parse deprecated field at first.Are these changes tested?
Yes.
Are there any user-facing changes?