Improve split_part udf by using a GenericStringBuilder #12093
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
approved these changes
Aug 21, 2024
Contributor
alamb
left a comment
alamb
left a comment
There was a problem hiding this comment.
Looks great to me -- thank you @Lordworms
I had some suggestions that could possibly make this PR better, but overall this look pretty good to me
| .map(|((string, delimiter), n)| match (string, delimiter, n) { | ||
| /// Splits string at occurrences of delimiter and returns the n'th field (counting from one). | ||
| /// split_part('abc~@~def~@~ghi', '~@~', 2) = 'def' | ||
| pub fn split_part<StringArrayLen: OffsetSizeTrait, DelimiterArrayLen: OffsetSizeTrait>( |
Contributor
There was a problem hiding this comment.
😍 love the function rather than macro
| n_array, | ||
| ) | ||
| } | ||
| (_, DataType::Utf8View) => split_part_impl::< |
Contributor
There was a problem hiding this comment.
I almost wonder if it would be simpler to call spit_part_impl directly from invoke
This extra level of indirection does save some repetition, but it might be clearer if all the possible combination of argument types were simply specified directly
alamb
approved these changes
Aug 22, 2024
|
|
||
| // Unpack the ArrayRefs from the arguments | ||
| let n_array = as_int64_array(&args[2])?; | ||
| let result = match (args[0].data_type(), args[1].data_type()) { |
| .zip($n_array.iter()) | ||
| .map(|((string, delimiter), n)| match (string, delimiter, n) { | ||
| /// impl | ||
| pub fn split_part_impl<'a, StringArrType, DelimiterArrType, StringArrayLen>( |
Contributor
There was a problem hiding this comment.
I think this is a nice pattern. Thanks @Lordworms
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #12084
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?