Skip to content

Conversation

@alamb
Copy link
Contributor

@alamb alamb commented Aug 14, 2024

Which issue does this PR close?

Follow on to #11959

Rationale for this change

I think the context for #11959 may not be obvious, so we should add a comment explaining that: #11959 (comment)

What changes are included in this PR?

  1. Add a comment with the rationale of including get_field
  2. Some drive by doc cleanuos

Are these changes tested?

Are there any user-facing changes?

Only doc changes, no functional changes

@alamb alamb marked this pull request as ready for review August 14, 2024 20:32
@github-actions github-actions bot added the functions Changes to functions implementation label Aug 14, 2024
));
}

/// Returns all DataFusion functions defined in this package
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

drive by cleanup

Copy link
Contributor

@jayzhan211 jayzhan211 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@jayzhan211 jayzhan211 merged commit e24a5dd into apache:main Aug 14, 2024
@alamb alamb deleted the alamb/function_docs branch August 15, 2024 11:15
@alamb
Copy link
Contributor Author

alamb commented Aug 15, 2024

Thanks @jayzhan211

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

functions Changes to functions implementation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants