Skip to content

Conversation

@PsiACE
Copy link
Member

@PsiACE PsiACE commented Aug 10, 2024

Which issue does this PR close?

Closes #11852 .

Rationale for this change

Ref #11787

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

@github-actions github-actions bot added the sqllogictest SQL Logic Tests (.slt) label Aug 10, 2024
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great @PsiACE -- thank you

I love it when adding functionality is done with a net deletion of code

Exact(vec![Utf8, LargeUtf8]),
Exact(vec![LargeUtf8, Utf8]),
Exact(vec![LargeUtf8, LargeUtf8]),
// Planner attempts coercion to the target type starting with the most preferred candidate.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️ for the comments

@alamb alamb merged commit 8deba02 into apache:main Aug 12, 2024
@PsiACE PsiACE deleted the ends_with branch August 12, 2024 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

sqllogictest SQL Logic Tests (.slt)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update ENDS_WITH scalar function to support Utf8View

2 participants