Improved unparser documentation #11395
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
sql
alamb
force-pushed
the
alamb/unparser_docs
branch
from
c60e132 to
eba6e60
Compare
Contributor
Author
|
FYI @devinjdangelo and @backkem |
backkem
approved these changes
Jul 12, 2024
github-actions
bot
removed
documentation
Contributor
Author
Yes, kudos belong to @backkem and @devinjdangelo for bringing the idea into DataFusion at first (from datafusion-federation) and to many contributors along the way that filled out the feature |
findepi
pushed a commit
to findepi/datafusion
that referenced
this pull request
Jul 16, 2024
xinlifoobar
pushed a commit
to xinlifoobar/datafusion
that referenced
this pull request
Jul 17, 2024
xinlifoobar
pushed a commit
to xinlifoobar/datafusion
that referenced
this pull request
Jul 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft as it builds on #11186Which issue does this PR close?
Follow on to #11186
Rationale for this change
While reviewing #11186 from @MohamedAbdeen21 I found some areas that the docs could be improved
What changes are included in this PR?
Add module level / function level / struct level docstrings and examples
Are these changes tested?
By CI doc tests
Are there any user-facing changes?
better docs