Improved ergonomy for CREATE EXTERNAL TABLE OPTIONS: Don't require quotations for simple namespaced keys like foo.bar
#10483
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
sql
ozankabak
commented
May 13, 2024
Comment on lines
465
to
476
| Token::Word(Word { value, .. }) => { | ||
| let mut parts = vec![value]; | ||
| while self.parser.consume_token(&Token::Period) { | ||
| let next_token = self.parser.next_token(); | ||
| if let Token::Word(Word { value, .. }) = next_token.token { | ||
| parts.push(value); | ||
| } else { | ||
| return self.parser.expected("key name", next_token); | ||
| } | ||
| } | ||
| Ok(parts.join(".")) | ||
| } |
Contributor
Author
There was a problem hiding this comment.
This is the main change, the rest is clean-up.
Contributor
Author
|
@berkaysynnada PTAL |
| OPTIONS ( | ||
| format.delimiter '|', | ||
| has_header false, | ||
| compression gzip); |
Contributor
|
This PR addresses the last remaining gap, ensuring that UX achieves the desired balance of consistency and flexibility. |
comphead
reviewed
May 13, 2024
alamb
reviewed
May 13, 2024
Contributor
There was a problem hiding this comment.
Thanks @ozankabak and @berkaysynnada and @comphead -- this looks really nice 👍
I think not only is UX better, the code is better as well
Contributor
Author
|
Thank you all for the reviews 🚀 |
findepi
pushed a commit
to findepi/datafusion
that referenced
this pull request
Jul 16, 2024
…quotations for simple namespaced keys like `foo.bar` (apache#10483) * Don't require quotations for simple namespaced keys like foo.bar * Add comments clarifying parse error cases for unquoted namespaced keys
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Quick follow-on to #10404.
Rationale for this change
Now that we migrated to a consistent options syntax for external tables, we should focus on user ergonomy. I don't see a reason why we require simple namespaced option keys like
foo.barto have explicit quotes.What changes are included in this PR?
Tweaked parser logic to allow quoteless namespaced keys for the
OPTIONSclause.Are these changes tested?
Added a new slt test to exercise the new code path.
Are there any user-facing changes?
Increased user ergonomy.