implement rewrite for FilterNullJoinKeys #10166
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lordworms
force-pushed
the
issue_9637_filter_null_join_key
branch
from
2837e72 to
8b4b002
Compare
31 tasks
alamb
approved these changes
Apr 22, 2024
Contributor
alamb
left a comment
alamb
left a comment
There was a problem hiding this comment.
Thank you @Lordworms -- this looks great. Very nice
| } | ||
|
|
||
| match plan { | ||
| LogicalPlan::Join(join) if join.join_type == JoinType::Inner => { |
Contributor
There was a problem hiding this comment.
Removing the clone() is beautiful 😍
Lordworms
force-pushed
the
issue_9637_filter_null_join_key
branch
from
a68422e to
b2252b5
Compare
alamb
reviewed
Apr 22, 2024
| .fold(not_null_exprs[0].clone(), |a, b| and(a, b.clone())) | ||
|
|
||
| // directly unwrap since it should always have a value | ||
| conjunction(not_null_exprs).unwrap() |
Contributor
|
Thanks again @Lordworms |
This was referenced Apr 24, 2024
ccciudatu
pushed a commit
to hstack/datafusion
that referenced
this pull request
Apr 26, 2024
This was referenced Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
part of #9637
Closes #.
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?