Planning error for compound expressions involving window functions

[2010YOUY01]

Describe the bug

The following query throws planning error for DataFusion, but it runs in DuckDB and PostgreSQL

Run in datafusion-cli (commit hash a28f283)

DataFusion CLI v45.0.0
> SELECT
  t1.v1,
  SUM(t1.v1) OVER w + 1
FROM
  generate_series(1, 10000) AS t1(v1)
WINDOW
  w AS (ORDER BY t1.v1 ROWS BETWEEN UNBOUNDED PRECEDING AND CURRENT ROW);

Error during planning: Projection references non-aggregate values: Expression t1.v1 could not be resolved from available columns: sum(t1.v1)

To Reproduce

No response

Expected behavior

No response

Additional context

No response

[qazxcdswe123]

After some digging I found that this only occur when using WINDOW clause.

So this one works

Failed with: Error during planning: Projection references non-aggregate values: Expression t1.v1 could not be resolved from available columns: sum(t1.v1)
SELECT
  t1.v1,
  SUM(t1.v1) OVER w + 1
FROM
  generate_series(1, 10) AS t1(v1)
WINDOW
  w AS (ORDER BY t1.v1);

Works:
SELECT
  t1.v1,
  SUM(t1.v1) OVER w
FROM
  generate_series(1, 10) AS t1(v1)
WINDOW
  w AS (ORDER BY t1.v1);
  
SELECT
  t1.v1,
  SUM(t1.v1) OVER (ORDER BY t1.v1) + 1
FROM
  generate_series(1, 10) AS t1(v1);

SELECT
  -- t1.v1,
  SUM(t1.v1) OVER w + 1
FROM
  generate_series(1, 10) AS t1(v1)
WINDOW
  w AS (ORDER BY t1.v1);

I think I can give it a try

[qazxcdswe123]

take

[qazxcdswe123]

I dont think I can fix this lol, I tried tweaking rebase_expr and check_columns_satisfy_exprs in datafusion/sql/src/utils.rs but all failed. The planner is little too complicated for me :D

untake

How can I untake this btw

[2010YOUY01]

I dont think I can fix this lol, I tried tweaking rebase_expr and check_columns_satisfy_exprs in datafusion/sql/src/utils.rs but all failed. The planner is little too complicated for me :D

untake

How can I untake this btw

Thanks for the attempt. The planning code is indeed quite complex.

[alamb]

See @chenkovsky's PR here:

• fix: nested window function #15033