Skip to content

Move StringArrayType, StringViewArrayBuilder, StringArrayBuilder & LargeStringArrayBuilder from functions/string/common.rs to a more common crate/module #12898

@Omega359

Description

@Omega359

Is your feature request related to a problem or challenge?

Currently the StringArrayType trait and the String*Builder structs are in the string crate however these are used in other crates (unicode, soon to include regex) and thus should be moved out to a more common location to not introduce needless dependencies between function crates.

Describe the solution you'd like

My first thought is to create a functions/string_common.rs file and move the above mentioned trait and structs to this file, update all code, remove crate dependencies and update any tests as required.

Describe alternatives you've considered

Leave things alone and allow the crate dependencies to stay.

Additional context

No response

Metadata

Metadata

Assignees

Labels

enhancementNew feature or request

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions