Skip to content

circular dependency check CI check is failing with compile error #11671

@alamb

Description

@alamb

Describe the bug

CI runs a dependencies check like https://github.com/apache/datafusion/blob/f715d8c6e52ede26ff5b260ad724c7f0c4608cc7/.github/workflows/dependencies.yml#L37-L36

To Reproduce

cd dev/depcheck
cargo run
error[E0283]: type annotations needed
  --> /Users/andrewlamb/.cargo/registry/src/index.crates.io-6f17d22bba15001f/gix-credentials-0.23.1/src/program/mod.rs:83:63
   |
83 |                 gix_command::prepare(gix_path::from_bstr(args.as_ref()).into_owned())
   |                                                               ^^^^^^
   |
   = note: multiple `impl`s satisfying `BString: AsRef<_>` found in the `bstr` crate:
           - impl AsRef<BStr> for BString;
           - impl AsRef<[u8]> for BString;
help: try using a fully qualified path to specify the expected types
   |
83 |                 gix_command::prepare(gix_path::from_bstr(<BString as AsRef<T>>::as_ref(&args)).into_owned())
   |                                                          +++++++++++++++++++++++++++++++    ~

error[E0283]: type annotations needed
   --> /Users/andrewlamb/.cargo/registry/src/index.crates.io-6f17d22bba15001f/gix-credentials-0.23.1/src/program/mod.rs:83:38
    |
83  |                 gix_command::prepare(gix_path::from_bstr(args.as_ref()).into_owned())
    |                                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ cannot infer type for reference `&_`
    |
    = note: multiple `impl`s satisfying `Cow<'_, BStr>: From<&_>` found in the `bstr` crate:
            - impl<'a> From<&'a BStr> for Cow<'a, BStr>;
            - impl<'a> From<&'a BString> for Cow<'a, BStr>;
    = note: required for `&_` to implement `Into<Cow<'_, BStr>>`
note: required by a bound in `from_bstr`
   --> /Users/andrewlamb/.cargo/registry/src/index.crates.io-6f17d22bba15001f/gix-path-0.10.9/src/convert.rs:135:34
    |
135 | pub fn from_bstr<'a>(input: impl Into<Cow<'a, BStr>>) -> Cow<'a, Path> {
    |                                  ^^^^^^^^^^^^^^^^^^^ required by this bound in `from_bstr`

For more information about this error, try `rustc --explain E0283`.

Expected behavior

Should run without compile error

Additional context

I found this while working #11667 where it failed for me:
https://github.com/apache/datafusion/actions/runs/10110055582/job/27959189057?pr=11667

I did notice that gix-credentials published a new version 0.24.4 yesterday (though strangely the compiler error is about a different version of the crate -- 23.1)

https://crates.io/crates/gix-credentials/0.24.4

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workingdevelopment-processRelated to development process of DataFusion

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions