Oracle: Support for MERGE predicates #2101
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Oracle supports small extensions to the standard MERGE syntax (that I'd need to support.) In particular:
... WHEN MATCHED ... UPDATE ... ***[WHERE <expr>] [DELETE WHERE <expr>]***... WHEN NOT MATCHED ... INSERT ... ***[WHERE <expr>]***Here's the documentation for reference.
Quoted column names
Additionally, Oracle also allows quoted names in
MERGE INTO a.b ... INSERT (a.b.col1, a.b.col2) ...(or event... INSERT (b.col1, b.col2) ...with the same meaning as... INSERT (col1, col2)as long asa.bdenotes the target table of the merge.For the sake of compatibility, this draft PR makes a trade-off: the parser validates that "a.b." corresponds to the target table, and strips away the prefix in order to keep
MergeInsertExpr::columnsaVec<Ident>. While preserving semantics, the implication is that such a parsed statements doesn't render back in the exact same form, though.Not doing the validation and stripping, we'd probably need to end up with a
Vec<QualifiedName>. I would be glad to hear your opinion how to move forward. Personally, I'd be fine with theVec<QualifiedName>allowing me to re-produce the statement as originally written.Note
Spannedfor MERGE statements #2100 as it made my work easier; it's only the latest commit that is relevant. I will continue rebasing / adopting this PR accordingly.Parser::merge_parse_clausesprivate.)Missing