make giscus comment section opt-in to comply with ASF policy
#106
+129
−23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 8, 2025
alamb
approved these changes
Sep 8, 2025
There was a problem hiding this comment.
Thank you @kevinjqliu -- I tried this out locally and the button seems to successfully show/hide giscuss
I also verified there was no network traffic until the button was clicked
Co-authored-by: Andrew Lamb <[email protected]>
|
thank you for the screenshot showing network traffic! I updated the PR with your suggestion |
|
Thanks again @kevinjqliu |
|
one step closer! thanks for the review |
thank you for pushing this forward |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #80
Add a new "Comments" section. Load
giscusonly after user explicitly opt-in, by clicking the "Show Comments" button.Explicit consent is required by the Apache Content Security Policy
Example of first visit:
After clicking "Show Comments":
After "Signing in with Github":