Building docker images during CI/CD and publish on tag #29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
austin362667
approved these changes
Oct 13, 2024
Contributor
austin362667
left a comment
austin362667
left a comment
There was a problem hiding this comment.
Looks good to me. Thank you @edmondop !
andygrove
reviewed
Oct 13, 2024
| @@ -0,0 +1,32 @@ | |||
| name: Kubernetes | |||
Member
There was a problem hiding this comment.
Could you add the ASF license header? It looks like we don't have the RAT checks set up in CI yet.
Member
There was a problem hiding this comment.
I would also be okay with explicitly excluding GitHub workflows from RAT checks if we had RAT set up, so maybe this is fine.
Member
There was a problem hiding this comment.
I'll go ahead and merge so we can test. I added a bullet to #2 for setting up RAT.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #28