Skip to content

Conversation

@kelvindart
Copy link

Platforms affected

[email protected]

What does this PR do?

Removes the dependency on cordova-plugin-compat, and includes checks for min platform version.

What testing has been done on this change?

Testing 1:

  • Add local plugin to project containing [email protected]
  • Verify plugin installs, and app runs.

Testing 2:

  • Add local plugin to project containing [email protected]
  • Verify plugin does not install.
  • Console log as follows:
Plugin doesn't support this project's cordova-android version. cordova-android: 6.2.3, failed version requirement: >=6.3.0
Skipping 'cordova-plugin-camera' for android

This is desirable - this change stops the plugin being installed on <[email protected]

Checklist

  • Reported an issue in the JIRA database
  • Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
  • Added automated test coverage as appropriate for this change.

@asfgit asfgit closed this in 2acda2d Oct 20, 2017
@stevengill
Copy link
Contributor

Thanks @kelvindart! I've merged it in

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants