CB-13421: (osx) Added macOS support

[JoseExposito]

HI all,

This pull request adds macOS support to cordova-plugin-camera.

I'm not sure if this project accepts new features, is open to community collaborations or even if I should be submitting this PR to git.apache.org... Some guidance will be truly appreciated 😄

Here is a little demo of how it works:

The JS code looks like:

document.querySelector('#testCamera').addEventListener('click', function() {
    navigator.camera.getPicture(onCameraOk, onError, {
        sourceType: Camera.PictureSourceType.CAMERA,
        destinationType: Camera.DestinationType.DATA_URL,
        allowEdit: true,
        encodingType: Camera.EncodingType.JPEG,
        quality: 100,
        targetWidth:  500,
        targetHeight: 100,
    })
})

document.querySelector('#testFile').addEventListener('click', function() {
    navigator.camera.getPicture(onFileOk, onError, {
        sourceType: Camera.PictureSourceType.PHOTOLIBRARY,
        destinationType: Camera.DestinationType.FILE_URI,
        encodingType: Camera.EncodingType.PNG,
        mediaType: Camera.MediaType.ALLMEDIA,
        targetWidth:  500,
        targetHeight: 100,
    })
})

As you can see it support image scale, PNG, JPEG, quality...

I'm interested in collaborate to migrate more plugins to macOS, but first I wanted to contact with the team to know if:

(1) The Cordova team is interested in supporting macOS and/or other desktop platforms
(2) I need to introduce any further changes in this pull request
(3) You are open to migrate all the other core plugins to macOS
(4) You are interested in supporting multi window in desktop platforms

Known issues: When adding the plugin to a project:

$ cordova plugin add https://github.com/JoseExposito/cordova-plugin-camera.git

It is necessary to open platforms/osx/HelloCordova.xcodeproj and manually add the plugin to platforms/osx/HelloCordova/config.xml:

<?xml version='1.0' encoding='utf-8'?>
<widget id="io.cordova.hellocordova" version="1.0.0" xmlns="http://www.w3.org/ns/widgets" xmlns:cdv="http://cordova.apache.org/ns/1.0">
    [...]
    <feature name="Camera">
        <param name="osx-package" value="CDVCamera" />
    </feature>
    [...]
</widget>

I noticed this happens with other Cordova core plugins with official macOS support like cordova-plugin-device or cordova-plugin-file.

I guess this is an issue with the osx platform. Could somebody help me to report this issue to the right project/maintainer?

[janpio]

Nice PR, as far as I understand it.

For your questions 1 to 4 you might want to email the dev list: https://cordova.apache.org/contact/ (My guess: Yes, No, Yes, Yes)

For the "known issue" I think you can open an additional issue at issues.cordova.io - this shouldn't be that way I think.

[JoseExposito]

I created a JIRA with the macOS bug:
https://issues.apache.org/jira/browse/CB-13424

[JoseExposito]

The plugin issue (https://issues.apache.org/jira/browse/CB-13424) is fixed in this pull request (apache/cordova-osx#43), it'll be nice to have both merged.

[stevengill]

@JoseExposito Thanks! This PR looks great. We are definitely open to having the other plugins add support for OSX.