Skip to content

Fix #1232: Reload issue resulting in white screen #1533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
+11 −3
Open

Fix #1232: Reload issue resulting in white screen #1533

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0d85a7d
(iOS) fix reload issue resulting in white screen
JH7 May 17, 2022
6aad603
resolved conflict for main repo
MrSpark2591 May 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions CordovaLib/Classes/Private/Plugins/CDVWebViewEngine/CDVWebViewEngine.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -285,7 +285,9 @@ - (void)dispose
- (void) onAppWillEnterForeground:(NSNotification*)notification {
if ([self shouldReloadWebView]) {
NSLog(@"%@", @"CDVWebViewEngine reloading!");
[(WKWebView*)_engineWebView reload];
NSURL* url = [((CDVViewController*) self.viewController) appUrl];
NSURLRequest* appReq = [NSURLRequest requestWithURL:url cachePolicy:NSURLRequestReloadIgnoringLocalCacheData timeoutInterval:20.0];
[self loadRequest:appReq];
}
}

Expand Down Expand Up @@ -562,7 +564,11 @@ - (void)webView:(WKWebView*)theWebView didFailNavigation:(WKNavigation*)navigati

- (void)webViewWebContentProcessDidTerminate:(WKWebView *)webView
{
[webView reload];
CDVViewController *vc = (CDVViewController *)self.viewController;
[vc showLaunchScreen:true];
NSURL* url = [vc appUrl];
NSURLRequest* appReq = [NSURLRequest requestWithURL:url cachePolicy:NSURLRequestReloadIgnoringLocalCacheData timeoutInterval:20.0];
[self loadRequest:appReq];
}

- (BOOL)defaultResourcePolicyForURL:(NSURL*)url
Expand Down
4 changes: 3 additions & 1 deletion CordovaLib/include/Cordova/CDVViewController.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,7 +195,9 @@ NS_ASSUME_NONNULL_BEGIN
@property (nonatomic, null_resettable, copy) IBInspectable UIColor *statusBarBackgroundColor;

- (UIView*)newCordovaViewWithFrame:(CGRect)bounds;

- (nullable NSString*)appURLScheme;
- (nullable NSURL*)errorURL;
- (NSURL*)appUrl;
/**
Returns the ``CDVPlugin`` instance of the given plugin name, creating the
instance if one does not exist.
Expand Down