make builder public under experimental #7825
Conversation
| mod test_util; | ||
|
|
||
| pub(crate) use builder::ArrayReaderBuilder; | ||
| // Note that this crate is public under the `experimental` feature flag. |
There was a problem hiding this comment.
I saw your comment #7521 (comment) @alamb , so added a line here to explain that this crate is public.
maybe it's also time to graduate this crate to remove experimental?
There was a problem hiding this comment.
If we are going to make it non experimental we I think we need to add tests (e.g. doctest) or something that shows how the public API is being used so we don't break it in the future.
I need to think about what the implications of making it pub are -- it may make more sense to do that if/when we have finally sorted out how what it takes to turn on filter pushdown
| mod test_util; | ||
|
|
||
| pub(crate) use builder::ArrayReaderBuilder; | ||
| // Note that this crate is public under the `experimental` feature flag. |
There was a problem hiding this comment.
If we are going to make it non experimental we I think we need to add tests (e.g. doctest) or something that shows how the public API is being used so we don't break it in the future.
I need to think about what the implications of making it pub are -- it may make more sense to do that if/when we have finally sorted out how what it takes to turn on filter pushdown
2 participants
Make
ArrayReaderBuilderpublic (under experimental), I think the ability to build array reader was public prior to#7521
This will allow downstream users to build their own array readers. This is also consistent with many other array readers that are public.