-
Notifications
You must be signed in to change notification settings - Fork 1k
Introduce MAX_INLINE_VIEW_LEN constant for string/byte views
#7719
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I will also run some benchmarks on this PR to make sure it doesn't mess with anything |
|
🤖 |
|
🤖: Benchmark completed Details
|
|
🤖 |
|
🤖: Benchmark completed Details
|
|
🤖 |
|
🤖: Benchmark completed Details
|
|
🤖 |
|
🤖: Benchmark completed Details
|
|
hah this shows the benchmarks are pretty stable when the compiled code is unchanged 😎 |
|
hah this shows the benchmarks are pretty stable when the compiled code is unchanged 😎 Indeed but there are still outliers like this (which shouldn't be impacted at all) 🤔
|
|
Thanks again @Dandandan for the review |
Which issue does this PR close?
As suggested by @Dandandan in #7650 (comment):
Rationale for this change
Using a symbolic constant in the code rather than a hard coded constant makes it easier to:
What changes are included in this PR?
MAX_INLINE_VIEW_LENconstant for string/byte views12Are there any user-facing changes?
A new constant