-
Couldn't load subscription status.
- Fork 1k
Support write to buffer api for SerializedFileWriter #7714
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
9b5a7f5
Support write to buffer api for SerializedFileWriter
zhuqi-lucas a291e4b
fmt
zhuqi-lucas c4ad0b3
add comments
zhuqi-lucas e7dd66e
Update parquet/src/file/writer.rs
zhuqi-lucas a39da8d
Address comments
zhuqi-lucas 5c52e40
fmt
zhuqi-lucas 8216ac1
address comments
zhuqi-lucas File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -394,9 +394,26 @@ impl<W: Write + Send> SerializedFileWriter<W> { | |
| self.buf.inner() | ||
| } | ||
|
|
||
| /// Writes the given buf bytes to the internal buffer. | ||
zhuqi-lucas marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| /// | ||
| /// This can be used to write raw data to an in-progress parquet file, for | ||
| /// example, custom index structures or other payloads. Other parquet readers | ||
| /// will skip this data when reading the files. | ||
| /// | ||
| /// It's safe to use this method to write data to the underlying writer, | ||
| /// because it will ensure that the buffering and byte‐counting layers are used. | ||
| pub fn write_all(&mut self, buf: &[u8]) -> std::io::Result<()> { | ||
| self.buf.write_all(buf) | ||
| } | ||
|
|
||
| /// Returns a mutable reference to the underlying writer. | ||
| /// | ||
| /// It is inadvisable to directly write to the underlying writer. | ||
| /// **Warning**: if you write directly to this writer, you will skip | ||
| /// the `TrackedWrite` buffering and byte‐counting layers. That’ll cause | ||
| /// the file footer’s recorded offsets and sizes to diverge from reality, | ||
| /// resulting in an unreadable or corrupted Parquet file. | ||
| /// | ||
| /// If you want to write safely to the underlying writer, use [`Self::write_all`]. | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ❤️ |
||
| pub fn inner_mut(&mut self) -> &mut W { | ||
| self.buf.inner_mut() | ||
| } | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you