Minor: Error rather than panic for unsupported for dictionary casting
#6456
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
approved these changes
Sep 25, 2024
Contributor
alamb
left a comment
alamb
left a comment
There was a problem hiding this comment.
Looks like an improvement to me -- thank you @goldmedal
alamb
changed the title
casting
Contributor
Author
|
It seems that the CI failure isn't related to this PR 🤔 ( It also fails on the main branch and other PRs) |
Contributor
Agree -- I believe it is #6448 |
alamb
changed the title
castingcasting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
no correlated issue.
Rationale for this change
While working on apache/datafusion#12621 (comment) , I got the panic from the arrow side. Instead of panicking, we can throw the ArrowError. It would be easier to trace the error for downstream projects (e.g. DataFusion).
What changes are included in this PR?
Remove
unwrap()and returnArrowErrorinstead.Are there any user-facing changes?
no