Fix CI by disabling newly failing rust <> nanoarrow integration test in CI #6449
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
changed the title
alamb
changed the title
gstvg
approved these changes
Sep 25, 2024
Contributor
Author
|
Thanks for the review @gstvg -- I am going to merge this one in to get CI clean again and then we'll proceed merging approved PRs |
Member
|
FWIW, #6426 and google/flatbuffers#8398 should fix #5052 |
This was referenced Sep 25, 2024
paleolimbot
added a commit
to apache/arrow-nanoarrow
that referenced
this pull request
Oct 7, 2024
Closes #641. Unfortunately we just have to skip checking Rust compatibility due to apache/arrow-rs#5052 (e.g., apache/arrow-rs#6449 ). This PR also ensures compatibility with big endian Arrow files and Arrow files from before the continuation token. Support for those had already been added in the decoder but hadn't made it to the stream reader yet. Local check: ```bash # Assumes arrow-testing, arrow-nanoarrow, and arrow are all checked out in the same dir export gold_dir=../arrow-testing/data/arrow-ipc-stream/integration export ARROW_NANOARROW_PATH=$(pwd)/build pip install -e "../arrow/dev/archery/[all]" archery integration --with-nanoarrow=true --run-ipc \ --gold-dirs=$gold_dir/0.14.1 \ --gold-dirs=$gold_dir/0.17.1 \ --gold-dirs=$gold_dir/1.0.0-bigendian \ --gold-dirs=$gold_dir/1.0.0-littleendian \ --gold-dirs=$gold_dir/2.0.0-compression \ --gold-dirs=$gold_dir/4.0.0-shareddict ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #6448
Rationale for this change
apache/arrow#43715 in arrow enabled nanoarrow in the overall arrow integration tests, but sadly they don't yet pass with rust (due to #5052 -- thanks @paleolimbot for the pointer 🙏 )
So let's disable the integration testing until they pass to get CI checks green
What changes are included in this PR?
Are there any user-facing changes?