ARROW-12504: Buffer::from_slice_ref set correct capacity #18
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tustvold
force-pushed
the
from-slice-ref-capacity
branch
from
b03f2ba to
766fb13
Compare
|
@jorgecarleitao can you take a look at this PR? |
|
Yeap, makes a lot of sense; great catch 👍 |
This was referenced Oct 18, 2025
This was referenced Oct 27, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A minor change, that quite possibly makes no performance difference in practice, as the subsequent call to extend_from_slice calls reserve with the correct data size, but thought it couldn't hurt to fix