Skip to content

Makes me wonder if build_to_thrift should return an Option, to make sure callers don't forget to check .valid(). #6064

@alamb

Description

@alamb

Is your feature request related to a problem or challenge? Please describe what you are trying to do.

@progval pointed out that the current API for building ColumnIndex requires users to remember to call valid()

          Makes me wonder if `build_to_thrift` should return an `Option`, to make sure callers don't forget to check `.valid()`.

Originally posted by @progval in #6042 (comment)

Describe the solution you'd like
Change ColumnIndexBuilder::build_to_thrift so it returns Option - specifically None if valid() is false

Describe alternatives you've considered

Additional context

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions