Path improvements
#546
Draft
Path improvements
#546
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Draft for now: everything should work but I'd like to know which of these changes would be welcome, if any. Thanks for maintaining this by the way 🙂 |
Contributor
Author
|
One alternative I'm considering is a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #545
Rationale for this change
fn prefix(&self)was the first thing I really wanted to have onPath, as opposed to copying from project to project.It also benefits from direct access to
raw. In userland we have to usepathsand collect, and omitting the last item is not trivial.What changes are included in this PR?
Implementations of everything listed with minimal docs, without tests.
Are there any user-facing changes?
Most of these changes are user-facing.
Internal changes:
impl FromIteratordelegates most of the logic toimpl ExpandPath::partsnow returns a custom iterator typeDELIMITER_CHARThere should be no breaking changes.