Fix Azure Paths Parsing being broken since 0.12.3 #443 #534
+8
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #443
Rationale for this change
Two of the downstream projects, delta-rs and datafusion used the parse function which was changed on #399
Which has led to those packages being rendered unusable with azure storage accounts since datafusion uses the direct https endpoints.
Delta-rs directly calls parse here:
https://github.com/delta-io/delta-rs/blob/main/crates/azure/src/lib.rs
What changes are included in this PR?
Modifying/Reverting the strip bucket command along with azurite tests to not make it happen again.
Container name should always be included as its not a bug.
Are there any user-facing changes?
These might break obstore changed based the changes on #399 like
developmentseed/obstore#477
Would need maintainers and collaborators to comment.