Skip to content

[object-store] Requested tokio version is too old - does not compile #46

@ashtuchkin

Description

@ashtuchkin

Describe the bug

Object store requests tokio="1.25.0" in it Cargo.toml, a pretty old version. If we have this version installed, it can't be compiled with the following error message:

error[E0624]: method `poll_join_next` is private
   --> /Systems/extlib/rust/object_store-0.11.0/src/upload.rs:155:31
    |
155 |             ready!(self.tasks.poll_join_next(cx)).unwrap()??
    |                               ^^^^^^^^^^^^^^ private method
    |
   ::: /Systems/extlib/rust/tokio-1.28.0/src/task/join_set.rs:365:5
    |
365 |     fn poll_join_next(&mut self, cx: &mut Context<'_>) -> Poll<Option<Result<T, JoinError>>> {
    |     ---------------------------------------------------------------------------------------- private method defined here

Naturally, poll_join_next was only made public in tokio 1.29.0 in this PR.

To Reproduce

Install tokio=1.25.0, object_store=0.11.0, observe the error message above when trying to compile.

Expected behavior

We should update tokio requirement to at least 1.29.0.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions