Add serialization helpers for Schema and RecordBatch #100
Conversation
Small refactoring of Flight-related code.
|
|
||
| cArray->n_buffers = 1; | ||
| cArray->buffers = (byte**)sharedOwner.Allocate(IntPtr.Size); | ||
| cArray->buffers[0] = null; |
There was a problem hiding this comment.
This was already checked-in as a separate change. Will rebase if necessary.
| { | ||
| // Translate an Apache.Arrow.Schema to FlatBuffer Schema to ByteString | ||
| // This should never have been a public class without a namespace | ||
| // TODO: Mark as obsolete once sufficient time has passed |
There was a problem hiding this comment.
Should we just mark this as obsolete now? Otherwise there's no indication that users should switch to something else. Either way, it would be good to add a comment to direct users to use ArrowSerializationHelpers.SerializeSchema instead if we don't want people using this.
There was a problem hiding this comment.
Yeah; I'd been thinking that marking it obsolete would break binary compatibility but of course that's not true so we may as well do it now.
| } | ||
|
|
||
| /// <summary> | ||
| /// This class handles writing schemas |
There was a problem hiding this comment.
It also writes RecordBatches. I can't think of a better name for it though.
There was a problem hiding this comment.
I guess I didn't look that closely at the code I moved ;).
Apply feedback from PR for #100: - Mark method as obsolete now instead of waiting - Fix comment
2 participants
Adds helpers for Schema and RecordBatch to allow them to be serialized and deserialized individually. Refactors Flight-related code slightly to make use of the new helpers.
Closes #31.