Skip to content

fixed what-if grade bug related to multiple semesters #250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 2, 2021
Merged

fixed what-if grade bug related to multiple semesters #250

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion js/grades.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,7 +173,8 @@ var fetchQueue = [];
throw new Error("Assignment details could not be read");
}

let pts = Number.parseFloat(json.section[0].period[0].assignment.filter(x => x.assignment_id == Number.parseInt(assignment.dataset.id.substr(2)))[0].max_points);
const assignments = json.section[0].period.reduce((prevVal,curVal)=> prevVal.concat(curVal.assignment),[]);//combines the assignment arrays from each period
let pts = Number.parseFloat(assignments.filter(x => x.assignment_id == assignment.dataset.id.substr(2))[0].max_points);
if (!assignment.classList.contains("dropped")) {
max += pts;
Logger.log(`Max points for assignment ${assignment.dataset.id.substr(2)} is ${pts}`);
Expand Down