remove solana-stake-program

[2501babe]

Problem

#7203 removed all usage of the native stake program itself in the agave codebase, switching the builtin to bpf stake, pulling the core bpf repo for genesis, and using a bpf stake binary for tests. #7645 deleted the native stake program implementation, in other words virtually all stake program code

to keep the enormous diff of #7645 trivial, we left behind a few utility functions that were used in other parts of the codebase. this pr removes solana-stake-program entirely

Summary of Changes

• everything in points.rs was already copied to runtime by someone other than myself. this is deleted with no additions
• config.rs and epoch_rewards.rs only exist to set up these accounts for genesis. this functionality is moved to runtime::genesis_utils since it is lowest on the dependency tree compared to genesis and genesis-utils
• stake_state.rs deserialization wrappers are mostly deleted and replaced with standard deserialize calls. a few are moved where they are used frequently and locally
• stake_state::create_account() is moved to a new runtime::stake_utils module. this is used in many places, the logic is very annoying, and it is only required for tests and cli so it shouldnt be added to stake interface. it is also copy-pasted to accounts-db behind dcou, the one place that cannot import runtime
• get_minimum_delegation() is also added to runtime::stake_utils. this is a trivial function that accepts a bool and returns 1 or 1*10^9. the main reason to keep it is that when we implement minimum delegation (under a new feature flag), this marks the places in agave that care about it
• switch anything that was getting structs, program id, etc from solana-stake-program to solana-stake-interface
• delete solana-stake-program in its entirety

Upgrade Path

after this lands, we will be free to reuse the solana-stake-program name on crates io for the bpf stake program

our timing here is actually impeccable. native stake reexports stake interface, so removing it is a major breaking change for downstream. but the entire package was marked unstable in agave 3.x, and master is now on 4.0 alpha. this means we can land this pr now with no issues

bpf stake is presently on 1.0, with a version bump (to 2.0 or 1.1 im not sure) planned. after this pr lands, we must skip bpf stake at least to 4.0 and then we can push to crates io. if any 4.x agave release hits crates io before this pr is merged, we should skip bpf stake to 5.0

[mergify]

The Firedancer team maintains a line-for-line reimplementation of the
native programs, and until native programs are moved to BPF, those
implementations must exactly match their Agave counterparts.
If this PR represents a change to a native program implementation (not
tests), please include a reviewer from the Firedancer team. And please
keep refactors to a minimum.

[mergify]

If this PR represents a change to the public RPC API:

1. Make sure it includes a complementary update to rpc-client/ (example)
2. Open a follow-up PR to update the JavaScript client @solana/kit (example)

Thank you for keeping the RPC clients in sync with the server API @2501babe.

[codecov-commenter]

Codecov Report

❌ Patch coverage is 98.35165% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 83.2%. Comparing base (6fb754f) to head (bebd047).
⚠️ Report is 12 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #8834   +/-   ##
=======================================
  Coverage    83.2%    83.2%           
=======================================
  Files         864      860    -4     
  Lines      375287   375284    -3     
=======================================
+ Hits       312389   312390    +1     
+ Misses      62898    62894    -4     

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[2501babe]

added both of you but this only needs one full review, i was thinking @grod220 could go over the detail since this relates to his de-floating (sinking?) work on stake-interface, while @joncinque might want to glance over and confirm there are no bigger-picture concerns eg with genesis or downstream projects

[joncinque]

Looks great on my side! Thanks for doing all the cleanup

[joncinque]

We've had to duplicate a function across accounts-db and runtime in the past, so I'm fine with it here

[joncinque]

Weird, this wasn't caught by clippy before?

[2501babe]

it looks like clippy doesnt detect useless test imports like it does code imports only used in tests. i went to add a useless test import in svm/ to double check it wasnt a weird build thing and turns out it already has at least one 😅

[grod220]

LGTM, great job!

[2501babe]

oh i remember why we hated the merge queue last time we tried it, it doesnt let you rewrite the final commit message. happily it looks like re-reviews arent needed for a rebase with the same base