Skip to content

Conversation

@vadorovsky
Copy link
Member

@vadorovsky vadorovsky commented Oct 31, 2025

Add a unit test which ensures that only one bank fork performs rewards computation during epoch boundary.

A prerequisite to #8065.

@vadorovsky vadorovsky marked this pull request as ready for review October 31, 2025 10:17
@codecov-commenter
Copy link

codecov-commenter commented Oct 31, 2025

Codecov Report

❌ Patch coverage is 95.00000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 83.2%. Comparing base (d19301e) to head (9daaa71).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##           master    #8802     +/-   ##
=========================================
- Coverage    83.2%    83.2%   -0.1%     
=========================================
  Files         861      863      +2     
  Lines      375556   373689   -1867     
=========================================
- Hits       312608   310972   -1636     
+ Misses      62948    62717    -231     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

HaoranYi
HaoranYi previously approved these changes Oct 31, 2025
Copy link

@HaoranYi HaoranYi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@vadorovsky vadorovsky added this pull request to the merge queue Nov 1, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Nov 1, 2025
@vadorovsky vadorovsky force-pushed the test-epoch-rewards-cache branch 4 times, most recently from c478d3d to 04c4c19 Compare November 3, 2025 17:20
@vadorovsky vadorovsky requested a review from HaoranYi November 4, 2025 07:51
HaoranYi
HaoranYi previously approved these changes Nov 4, 2025
@vadorovsky vadorovsky added this pull request to the merge queue Nov 4, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 4, 2025
Add a unit test which ensures that only one bank fork performs rewards
computation during epoch boundary.

Co-authored-by: Danele Murua <[email protected]>
@vadorovsky vadorovsky enabled auto-merge November 4, 2025 17:04
@vadorovsky vadorovsky added this pull request to the merge queue Nov 4, 2025
Merged via the queue into anza-xyz:master with commit e1634f7 Nov 4, 2025
44 checks passed
@vadorovsky vadorovsky deleted the test-epoch-rewards-cache branch November 4, 2025 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants