runtime: Avoid redundant collections of stake delegations into a vector #7770
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Stake delegations are stored in an
im::HashMap, which is convenient to use as a per-bank cache, because of its CoW properties:clone()is just copying a pointer and increasing a reference counterHowever,
im::HashMap:par_bridgeperforms even worse than a single-threaded iteration - it takes 1.3sTherefore, it's better to
collect()theim::HashMapbefore calculating rewards.The problem is that there were two
collect()calls made during one epoch boundary.Summary of Changes
Fix that by collecting only once and passing the vector of delegations along.