Skip to content

Conversation

@buffalojoec
Copy link

@buffalojoec buffalojoec commented Apr 4, 2025

Problem

The Address Lookup Table builtin has been migrated to BPF on all clusters. It's being used in the scheduler cost model tests within solana-core, but we should probably swap it out for another builtin that won't be migrated, so the tests can remain in-tact as we evict the Address Lookup Table builtin source from the monorepo.

Summary of Changes

First, refactor the tests a bit so that we are using a bank that has been registered with the corresponding bank fork graph. This is important, since we will need a valid fork graph in order to perform a successful program deployment, which is the instruction we'll add to the tests.

Then, swap out the Address Lookup Table instruction for that of BPF Loader v3's DeployWithMaxDataLen, and adjust the cost modeling expected values accordingly.

@buffalojoec buffalojoec requested a review from tao-stones April 4, 2025 08:36
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.3%. Comparing base (07aa793) to head (68360cd).

Additional details and impacted files
@@            Coverage Diff            @@
##           master    #5645     +/-   ##
=========================================
- Coverage    83.3%    83.3%   -0.1%     
=========================================
  Files         824      824             
  Lines      373322   373322             
=========================================
- Hits       311209   311179     -30     
- Misses      62113    62143     +30     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link

@tao-stones tao-stones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks for updating tests. Eventually when loaders v3 is upgraded, and V4 is migrated to bpf, these tests can be removed for good.

@buffalojoec buffalojoec merged commit 8b33d6d into anza-xyz:master Apr 4, 2025
58 checks passed
@buffalojoec buffalojoec deleted the refactor-simd-0170-tests branch April 5, 2025 03:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants