Remove Cuda

CHANGELOG.md

@@ -28,6 +28,7 @@ Release channels have their own copy of this changelog:
   * Add `--snapshot-zstd-compression-level` to set the compression level when archiving snapshots with zstd.
   * SDK:
     * `cargo-build-sbf`: add `--skip-tools-install` flag to avoid downloading platform tools and `--no-rustup-override` flag to not use rustup when invoking `cargo`. Useful for immutable environments like Nix.
+  * Remove support for `--cuda` from `agave-validator`
 
 ## 2.1.0
 * Breaking:

core/src/banking_trace.rs

@@ -62,7 +62,7 @@ pub struct BankingTracer {
 #[cfg_attr(
     feature = "frozen-abi",
     derive(AbiExample),
-    frozen_abi(digest = "DAdZnX6ijBWaxKAyksq4nJa6PAZqT4RShZqLWTtNvyAM")
+    frozen_abi(digest = "ELQv6gP2vrcsw6wbbeDsQzgp8dVUgywxqxXXUpVzCsdX")
 )]
 #[derive(Serialize, Deserialize, Debug)]
 pub struct TimedTracedEvent(pub std::time::SystemTime, pub TracedEvent);

core/src/replay_stage.rs

@@ -34,7 +34,6 @@ use {
     crossbeam_channel::{Receiver, RecvTimeoutError, Sender},
     rayon::{prelude::*, ThreadPool},
     solana_accounts_db::contains::Contains,
-    solana_entry::entry::VerifyRecyclers,
     solana_geyser_plugin_manager::block_metadata_notifier_interface::BlockMetadataNotifierArc,
     solana_gossip::cluster_info::ClusterInfo,
     solana_ledger::{
@@ -603,7 +602,6 @@ impl ReplayStage {
             rpc_subscriptions.clone(),
         );
         let run_replay = move || {
-            let verify_recyclers = VerifyRecyclers::default();
             let _exit = Finalizer::new(exit.clone());
             let mut identity_keypair = cluster_info.keypair().clone();
             let mut my_pubkey = identity_keypair.pubkey();
@@ -732,7 +730,6 @@ impl ReplayStage {
                     transaction_status_sender.as_ref(),
                     cache_block_meta_sender.as_ref(),
                     entry_notification_sender.as_ref(),
-                    &verify_recyclers,
                     &mut heaviest_subtree_fork_choice,
                     &replay_vote_sender,
                     &bank_notification_sender,
@@ -2237,7 +2234,6 @@ impl ReplayStage {
         transaction_status_sender: Option<&TransactionStatusSender>,
         entry_notification_sender: Option<&EntryNotifierSender>,
         replay_vote_sender: &ReplayVoteSender,
-        verify_recyclers: &VerifyRecyclers,
         log_messages_bytes_limit: Option<usize>,
         prioritization_fee_cache: &PrioritizationFeeCache,
     ) -> result::Result<usize, BlockstoreProcessorError> {
@@ -2257,7 +2253,6 @@ impl ReplayStage {
             transaction_status_sender,
             entry_notification_sender,
             Some(replay_vote_sender),
-            verify_recyclers,
             false,
             log_messages_bytes_limit,
             prioritization_fee_cache,
@@ -2915,7 +2910,6 @@ impl ReplayStage {
         progress: &mut ProgressMap,
         transaction_status_sender: Option<&TransactionStatusSender>,
         entry_notification_sender: Option<&EntryNotifierSender>,
-        verify_recyclers: &VerifyRecyclers,
         replay_vote_sender: &ReplayVoteSender,
         replay_timing: &mut ReplayLoopTiming,
         log_messages_bytes_limit: Option<usize>,
@@ -3000,7 +2994,6 @@ impl ReplayStage {
                             transaction_status_sender,
                             entry_notification_sender,
                             &replay_vote_sender.clone(),
-                            &verify_recyclers.clone(),
                             log_messages_bytes_limit,
                             prioritization_fee_cache,
                         );
@@ -3030,7 +3023,6 @@ impl ReplayStage {
         progress: &mut ProgressMap,
         transaction_status_sender: Option<&TransactionStatusSender>,
         entry_notification_sender: Option<&EntryNotifierSender>,
-        verify_recyclers: &VerifyRecyclers,
         replay_vote_sender: &ReplayVoteSender,
         replay_timing: &mut ReplayLoopTiming,
         log_messages_bytes_limit: Option<usize>,
@@ -3089,7 +3081,6 @@ impl ReplayStage {
                     transaction_status_sender,
                     entry_notification_sender,
                     &replay_vote_sender.clone(),
-                    &verify_recyclers.clone(),
                     log_messages_bytes_limit,
                     prioritization_fee_cache,
                 );
@@ -3407,7 +3398,6 @@ impl ReplayStage {
         transaction_status_sender: Option<&TransactionStatusSender>,
         cache_block_meta_sender: Option<&CacheBlockMetaSender>,
         entry_notification_sender: Option<&EntryNotifierSender>,
-        verify_recyclers: &VerifyRecyclers,
         heaviest_subtree_fork_choice: &mut HeaviestSubtreeForkChoice,
         replay_vote_sender: &ReplayVoteSender,
         bank_notification_sender: &Option<BankNotificationSenderConfig>,
@@ -3454,7 +3444,6 @@ impl ReplayStage {
                     progress,
                     transaction_status_sender,
                     entry_notification_sender,
-                    verify_recyclers,
                     replay_vote_sender,
                     replay_timing,
                     log_messages_bytes_limit,
@@ -3474,7 +3463,6 @@ impl ReplayStage {
                         progress,
                         transaction_status_sender,
                         entry_notification_sender,
-                        verify_recyclers,
                         replay_vote_sender,
                         replay_timing,
                         log_messages_bytes_limit,
@@ -5062,7 +5050,6 @@ pub(crate) mod tests {
                 None,
                 None,
                 &replay_vote_sender,
-                &VerifyRecyclers::default(),
                 None,
                 &PrioritizationFeeCache::new(0u64),
             );
@@ -9138,7 +9125,6 @@ pub(crate) mod tests {
         // Set up bank0
         let bank_forks = BankForks::new_rw_arc(Bank::new_for_tests(&genesis_config));
         let bank0 = bank_forks.read().unwrap().get_with_scheduler(0).unwrap();
-        let recyclers = VerifyRecyclers::default();
         let replay_tx_thread_pool = rayon::ThreadPoolBuilder::new()
             .num_threads(1)
             .thread_name(|i| format!("solReplayTx{i:02}"))
@@ -9150,7 +9136,6 @@ pub(crate) mod tests {
             &blockstore,
             &replay_tx_thread_pool,
             &ProcessOptions::default(),
-            &recyclers,
             None,
             None,
         );
@@ -9171,7 +9156,6 @@ pub(crate) mod tests {
             &bank1,
             &replay_tx_thread_pool,
             &ProcessOptions::default(),
-            &recyclers,
             &mut ConfirmationProgress::new(bank0.last_blockhash()),
             None,
             None,

core/src/sigverify.rs

@@ -1,25 +1,22 @@
 //! The `sigverify` module provides digital signature verification functions.
 //! By default, signatures are verified in parallel using all available CPU
-//! cores.  When perf-libs are available signature verification is offloaded
-//! to the GPU.
+//! cores.
 //!
 
 pub use solana_perf::sigverify::{
-    count_packets_in_batches, ed25519_verify_cpu, ed25519_verify_disabled, init, TxOffset,
+    count_packets_in_batches, ed25519_verify_cpu, ed25519_verify_disabled, TxOffset,
 };
 use {
     crate::{
         banking_trace::BankingPacketSender,
         sigverify_stage::{SigVerifier, SigVerifyServiceError},
     },
     agave_banking_stage_ingress_types::BankingPacketBatch,
-    solana_perf::{cuda_runtime::PinnedVec, packet::PacketBatch, recycler::Recycler, sigverify},
+    solana_perf::{packet::PacketBatch, sigverify},
 };
 
 pub struct TransactionSigVerifier {
     packet_sender: BankingPacketSender,
-    recycler: Recycler<TxOffset>,
-    recycler_out: Recycler<PinnedVec<u8>>,
     reject_non_vote: bool,
 }
 
@@ -31,11 +28,8 @@ impl TransactionSigVerifier {
     }
 
     pub fn new(packet_sender: BankingPacketSender) -> Self {
-        init();
         Self {
             packet_sender,
-            recycler: Recycler::warmed(50, 4096),
-            recycler_out: Recycler::warmed(50, 4096),
             reject_non_vote: false,
         }
     }
@@ -58,13 +52,7 @@ impl SigVerifier for TransactionSigVerifier {
         mut batches: Vec<PacketBatch>,
         valid_packets: usize,
     ) -> Vec<PacketBatch> {
-        sigverify::ed25519_verify(
-            &mut batches,
-            &self.recycler,
-            &self.recycler_out,
-            self.reject_non_vote,
-            valid_packets,
-        );
+        sigverify::ed25519_verify(&mut batches, self.reject_non_vote, valid_packets);
         batches
     }
 }

core/src/validator.rs

@@ -21,7 +21,6 @@ use {
             serve_repair_service::ServeRepairService,
         },
         sample_performance_service::SamplePerformanceService,
-        sigverify,
         snapshot_packager_service::{PendingSnapshotPackages, SnapshotPackagerService},
         stats_reporter_service::StatsReporterService,
         system_monitor_service::{
@@ -695,14 +694,6 @@ impl Validator {
             info!("entrypoint: {:?}", cluster_entrypoint);
         }
 
-        if solana_perf::perf_libs::api().is_some() {
-            info!("Initializing sigverify, this could take a while...");
-        } else {
-            info!("Initializing sigverify...");
-        }
-        sigverify::init();
-        info!("Initializing sigverify done.");
-
         if !ledger_path.is_dir() {
             return Err(anyhow!(
                 "ledger directory does not exist or is not accessible: {ledger_path:?}"

docs/src/clusters/benchmark.md

@@ -67,15 +67,6 @@ To run a multinode testnet, after starting a leader node, spin up some additiona
 NDEBUG=1 ./multinode-demo/validator-x.sh
 ```
 
-To run a performance-enhanced validator on Linux, [CUDA 10.0](https://developer.nvidia.com/cuda-downloads) must be installed on your system:
-
-```bash
-./fetch-perf-libs.sh
-NDEBUG=1 SOLANA_CUDA=1 ./multinode-demo/bootstrap-validator.sh
-NDEBUG=1 SOLANA_CUDA=1 ./multinode-demo/validator.sh
-```
-
-
 ### Testnet Client Demo
 
 Now that your singlenode or multinode testnet is up and running let's send it some transactions!

docs/src/operations/guides/validator-start.md

@@ -29,14 +29,6 @@ solana transaction-count
 View the [metrics dashboard](https://metrics.solana.com:3000/d/monitor-edge/cluster-telemetry) for more
 detail on cluster activity.
 
-## Enabling CUDA
-
-If your machine has a GPU with CUDA installed \(Linux-only currently\), include
-the `--cuda` argument to `agave-validator`.
-
-When your validator is started look for the following log message to indicate
-that CUDA is enabled: `"[<timestamp> solana::validator] CUDA is enabled"`
-
 ## System Tuning
 
 ### Linux

entry/benches/entry_sigverify.rs

@@ -1,7 +1,7 @@
 #![feature(test)]
 extern crate test;
 use {
-    solana_entry::entry::{self, VerifyRecyclers},
+    solana_entry::entry,
     solana_hash::Hash,
     solana_message::SimpleAddressLoader,
     solana_perf::test_tx::test_tx,
@@ -52,14 +52,11 @@ fn bench_gpusigverify(bencher: &mut Bencher) {
         }
     };
 
-    let recycler = VerifyRecyclers::default();
-
     bencher.iter(|| {
         let res = entry::start_verify_transactions(
             entries.clone(),
             false,
             &thread_pool,
-            recycler.clone(),
             Arc::new(verify_transaction),
         );