[SWIFT] Add Antlr4Dynamic product #4363
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Grzegorz Spryszyński <[email protected]>
|
Hi. how certain are you that this change is correct for all of the swift folks? |
Hi, it will be invisible for most of them. it doesn't brake current setups. It is logical addition to the current target |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SPM cannot always properly recognise dependency type (dynamic or static) so it would be useful to be able to explicitly specify if static or dynamic is needed.
This is the case when eg. dependency is provided not as a source code but rather as a binary and dependency is already fixed into the file.
SPM is not able to detect binary dependencies. There is also no way to specify type of binary's dependencies.
There is already Antlr4Static in Package.swift so dynamic equivalent should be added for completeness.
This PR brings back the change that as introduced a year ago but was later overwritten by dev to master merge.