Fix Memory Leak Risk of Cpp Target #4330
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wangtao9
changed the title
Merged
Signed-off-by: wangtao9 <[email protected]>
wangtao9
force-pushed
the
fix_cpp_leak_risk
branch
from
ce6649a to
cefa47a
Compare
|
That's it, I've rebased the latest dev branch and all checks passed! Before this fix, there was a risk of a memory leak when threads exited prematurely, which was also reported by the asan (AddressSanitizer) check. This PR fixes the above problem, you can use this example to verify the effect: https://github.com/wangtao9/antlr4-perfopt-test/tree/sanitizer_check |
Signed-off-by: wangtao9 <[email protected]>
wangtao9
force-pushed
the
fix_cpp_leak_risk
branch
from
a74ad9e to
b4ffd43
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #4237 for details: