- 
                Notifications
    You must be signed in to change notification settings 
- Fork 3.4k
Fix for @4325--python2 testing not available on Github Actions. #4326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Closed
      
      
    
  
     Closed
                    Changes from 2 commits
      Commits
    
    
            Show all changes
          
          
            11 commits
          
        
        Select commit
          Hold shift + click to select a range
      
      9eaa38f
              
                Fix for @4325--python2 testing not available on Github Actions.
              
              
                kaby76 0047922
              
                Removing Python2 from additional places.
              
              
                kaby76 d3048ce
              
                Updates instructions for Python target.
              
              
                kaby76 768b937
              
                Simplify the example code a bit.
              
              
                kaby76 4512109
              
                Correct and clarify the language for the Python3 target.
              
              
                kaby76 9ada663
              
                Fix for @4325--python2 testing not available on Github Actions.
              
              
                kaby76 a331fe9
              
                Removing Python2 from additional places.
              
              
                kaby76 0cdd7c0
              
                Updates instructions for Python target.
              
              
                kaby76 f78d5e1
              
                Simplify the example code a bit.
              
              
                kaby76 3d043f9
              
                Correct and clarify the language for the Python3 target.
              
              
                kaby76 2ccf69a
              
                Merge branch 'antlr-4325' of https://github.com/kaby76/antlr4 into an…
              
              
                kaby76 File filter
Filter by extension
Conversations
          Failed to load comments.   
        
        
          
      Loading
        
  Jump to
        
          Jump to file
        
      
      
          Failed to load files.   
        
        
          
      Loading
        
  Diff view
Diff view
There are no files selected for viewing
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              | Original file line number | Diff line number | Diff line change | 
|---|---|---|
|  | @@ -174,7 +174,6 @@ jobs: | |
| javascript, | ||
| typescript, | ||
| php, | ||
| python2, | ||
| python3, | ||
| # swift, | ||
| ] | ||
|  | @@ -233,13 +232,6 @@ jobs: | |
| if: startswith(matrix.os, 'windows') && (matrix.target == 'cpp') | ||
| uses: microsoft/[email protected] | ||
|  | ||
| - name: Set up Python 2 | ||
| if: matrix.target == 'python2' | ||
| uses: actions/setup-python@v4 | ||
| with: | ||
| python-version: '2.x' | ||
| architecture: 'x64' | ||
|  | ||
| - name: Set up Python 3 | ||
| if: matrix.target == 'python3' | ||
| uses: actions/setup-python@v4 | ||
|  | @@ -316,7 +308,6 @@ jobs: | |
| cd runtime-testsuite | ||
| switch ("${{ matrix.target }}") | ||
| { | ||
| python2 { mvn -X '-Dantlr-python2-exec="${{ env.pythonLocation }}\python.exe"' '-Dtest=python2.**' test } | ||
| python3 { mvn -X '-Dantlr-python3-exec="${{ env.pythonLocation }}\python.exe"' '-Dtest=python3.**' test } | ||
| default { mvn -X '-Dtest=${{ matrix.target }}.**' test } | ||
| } | ||
|  | @@ -331,7 +322,6 @@ jobs: | |
|  | ||
| cd runtime-testsuite | ||
| case ${{ matrix.target }} in | ||
| python2) mvn -X '-Dantlr-python2-exec=${{ env.pythonLocation }}/bin/python' '-Dtest=python2.**' test ;; | ||
| python3) mvn -X '-Dantlr-python3-exec=${{ env.pythonLocation }}/bin/python' '-Dtest=python3.**' test ;; | ||
| *) mvn -X '-Dtest=${{ matrix.target }}.**' test ;; | ||
| esac | ||
|  | ||
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              | Original file line number | Diff line number | Diff line change | 
|---|---|---|
| @@ -1,5 +1,5 @@ | ||
| # Integrating ANTLR into Development Systems | ||
|  | ||
| The Java target is the reference implementation mirrored by other targets. The following pages help you integrate ANTLR into development environments and build systems appropriate for your target language. As of December 2016, we have Java, C#, Python 2, Python 3, JavaScript, Go, C++, and Swift targets. | ||
| The Java target is the reference implementation mirrored by other targets. The following pages help you integrate ANTLR into development environments and build systems appropriate for your target language. As of December 2016, we have Java, C#, Python 3, JavaScript, Go, C++, and Swift targets. | ||
|  | ||
| The easiest thing is probably just to use an [ANTLR plug-in](http://www.antlr.org/tools.html) for your favorite development environment. | 
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              | Original file line number | Diff line number | Diff line change | 
|---|---|---|
|  | @@ -2,17 +2,11 @@ | |
|  | ||
| The examples from the ANTLR 4 book converted to Python are [here](https://github.com/jszheng/py3antlr4book). | ||
|  | ||
| There are 2 Python targets: `Python2` and `Python3`. This is because there is only limited compatibility between those 2 versions of the language. Please refer to the [Python documentation](https://wiki.python.org/moin/Python2orPython3) for full details. | ||
| There is ONE Python target: `Python3`. This is because there is only limited compatibility between those 2 versions of the language. Please refer to the [Python documentation](https://wiki.python.org/moin/Python3) for full details. | ||
|  | ||
| How to create a Python lexer or parser? | ||
| This is pretty much the same as creating a Java lexer or parser, except you need to specify the language target, for example: | ||
|  | ||
| ``` | ||
| $ antlr4 -Dlanguage=Python2 MyGrammar.g4 | ||
| ``` | ||
|  | ||
| or | ||
|  | ||
| ``` | ||
| $ antlr4 -Dlanguage=Python3 MyGrammar.g4 | ||
| ``` | ||
|  | @@ -21,9 +15,8 @@ For a full list of antlr4 tool options, please visit the tool documentation page | |
|  | ||
| ## Where can I get the runtime? | ||
|  | ||
| Once you've generated the lexer and/or parser code, you need to download the runtime. The Python runtimes are available from PyPI: | ||
| Once you've generated the lexer and/or parser code, you need to download the runtime. The Python runtime are available from PyPI: | ||
|          | ||
|  | ||
| * https://pypi.python.org/pypi/antlr4-python2-runtime/ | ||
| * https://pypi.python.org/pypi/antlr4-python3-runtime/ | ||
|  | ||
| The runtimes are provided in the form of source code, so no additional installation is required. | ||
|  | ||
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              | Original file line number | Diff line number | Diff line change | 
|---|---|---|
|  | @@ -28,5 +28,4 @@ Go | |
| JavaScript | ||
| TypeScript | ||
| PHP | ||
| Python2 | ||
| Python3 | ||
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              | Original file line number | Diff line number | Diff line change | 
|---|---|---|
|  | @@ -51,7 +51,6 @@ between X1 and X2 or between X3 and X4 | |
| ; | ||
|  | ||
| [skip] | ||
| Python2 | ||
| Python3 | ||
| JavaScript | ||
| TypeScript | ||
|  | ||
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              | Original file line number | Diff line number | Diff line change | 
|---|---|---|
|  | @@ -41,5 +41,4 @@ Go | |
| JavaScript | ||
| TypeScript | ||
| PHP | ||
| Python2 | ||
| Python3 | ||
      
      Oops, something went wrong.
        
    
  
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess this can be rephrased a bit ?