Skip to content

Conversation

@ericvergnaud
Copy link
Contributor

@ericvergnaud ericvergnaud commented Jun 19, 2023

Fixes #4318

Signed-off-by: Eric Vergnaud <[email protected]>
@kaby76 kaby76 mentioned this pull request Jun 27, 2023
@ericvergnaud
Copy link
Contributor Author

@parrt please merge

@mike-lischke
Copy link
Member

@ericvergnaud You can cancel this PR. I will add this change to the typings (and a few other things in that file).

@parrt
Copy link
Member

parrt commented Sep 4, 2023

Will pull this in for 4.13.1

@parrt parrt merged commit d13d47c into antlr:dev Sep 4, 2023
@ericvergnaud ericvergnaud deleted the fix-bug-4318 branch September 5, 2023 09:59
teverett pushed a commit to antlr/grammars-v4 that referenced this pull request Sep 15, 2023
* Fix for #3125

Update build script to extract runtime version from composer.json, then find the tool version from online sources. Add in PHP testing.

* Update Pwsh build.ps1 script.

* Remove build-pwsh PHP -- it is tested with build-bash.

* Update desc.xml to remove PHP testing for two grammars.

* Fix compiler error for TypeScript target.

Fixed to use corrected API. antlr/antlr4#4319
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[typescript] Runtime declares CommonToken(source, .....) wrong.

3 participants