Skip to content

Conversation

@agatti
Copy link
Contributor

@agatti agatti commented Jun 15, 2023

XPath support still retained Python3 type annotations. This yields a partial installation when using setuptools on both plain Python2

byte-compiling build/bdist.linux-x86_64/egg/antlr4/xpath/XPath.py to XPath.pyc
  File "build/bdist.linux-x86_64/egg/antlr4/xpath/XPath.py", line 69
    def __init__(self, parser:Parser, path:str):
                             ^
SyntaxError: invalid syntax

or Jython

Extracting antlr4_python2_runtime-4.13.0-py2.7.egg to build/jython/Lib/site-packages
SyntaxError: ("mismatched input ':' expecting RPAREN", ('build/jython/Lib/site-packages/antlr4_python2_runtime-4.13.0-py2.7.egg/antlr4/xpath/XPath.py', 69, 29, '    def __init__(self, parser:Parser, path:str):\n'))

@ericvergnaud
Copy link
Contributor

@parrt blessed

@parrt parrt added this to the 4.13.1 milestone Jun 15, 2023
@parrt parrt merged commit d2e2584 into antlr:master Jun 15, 2023
@agatti agatti deleted the fix-python2-jython branch June 16, 2023 03:18
@KvanTTT
Copy link
Member

KvanTTT commented Jun 16, 2023

It was merged to the master branch, it's strange.

@ericvergnaud
Copy link
Contributor

I guess I didn't noticed the PR was against master, my bad.
Would you know a way of preventing that, or at minimal default to dev ?

@KvanTTT
Copy link
Member

KvanTTT commented Jun 16, 2023

I know only about changing default to dev. I don't like that branch should be changed for every MR because it cause error like this.

@ericvergnaud
Copy link
Contributor

Ok, I've switched the default branch to 'dev' such that future PRs should be against dev.
@parrt FYI

@parrt
Copy link
Member

parrt commented Jun 16, 2023

thanks guys...

@jimidle
Copy link
Collaborator

jimidle commented Jun 19, 2023 via email

@agatti agatti mentioned this pull request Jul 3, 2023
@parrt parrt modified the milestones: 4.14.0, 4.13.2 Aug 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants