Extract unit test updates by @ericvergnaud needed for TypeScript #4029
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rebase after we merge this into dev. All tests pass locally (didn't check python2 actually but python3 works). Signed-off-by: Terence Parr <[email protected]>
|
@ericvergnaud ready for your review once tests pass. |
Merged
KvanTTT
reviewed
Dec 20, 2022
added a line as I understand it. @ericvergnaud ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extract unit test updates by @ericvergnaud in #4027 then he can rebase after we merge this into dev. All tests pass locally (didn't check python2 actually but python3 works).
Eric needed these changes so he can have more fine grained control over fields of rule ctx objects.
Signed-off-by: Terence Parr [email protected]