test: Add test to check PyFluent launched PyConsole by default.

[prmukherj]

Add test to check PyFluent launched PyConsole by default.

[hpohekar]

@prmukherj

This is incorrect behaviour. We need to resolve this. The issue description already states that we must add unit test with fix.

We just need to update the following condition and I can confirm that it resolves this issue.

from ansys.fluent.core import config

if (
            (fluent_version and fluent_version >= FluentVersion.v251) or config.fluent_root
            and self.argvals["py"] is None
        ):
            self.argvals["py"] = True

https://github.com/ansys/pyfluent/blob/main/src/ansys/fluent/core/launcher/standalone_launcher.py#L207

cc: @seanpearsonuk @mkundu1

[prmukherj]

@prmukherj

This is incorrect behaviour. We need to resolve this. The issue description already states that we must add unit test with fix.

We just need to update the following condition and I can confirm that it resolves this issue.

from ansys.fluent.core import config

if (
            (fluent_version and fluent_version >= FluentVersion.v251) or config.fluent_root
            and self.argvals["py"] is None
        ):
            self.argvals["py"] = True

https://github.com/ansys/pyfluent/blob/main/src/ansys/fluent/core/launcher/standalone_launcher.py#L207

cc: @seanpearsonuk @mkundu1

I don't think it makes sense. I think the earlier behaviour was more correct. What if user sets fluent_root to 22R2?

[prmukherj]

@prmukherj
This is incorrect behaviour. We need to resolve this. The issue description already states that we must add unit test with fix.
We just need to update the following condition and I can confirm that it resolves this issue.

from ansys.fluent.core import config

if (
            (fluent_version and fluent_version >= FluentVersion.v251) or config.fluent_root
            and self.argvals["py"] is None
        ):
            self.argvals["py"] = True

https://github.com/ansys/pyfluent/blob/main/src/ansys/fluent/core/launcher/standalone_launcher.py#L207
cc: @seanpearsonuk @mkundu1

I don't think it makes sense. I think the earlier behaviour was more correct. What if user sets fluent_root to 22R2?

Moreover, if we want to make this change, '_get_standalone_launch_fluent_version' is the correct place to do so I believe.

[mkundu1]

@prmukherj If we directly use StandaloneLauncher class + dry_run, will we able to run it in github?

[prmukherj]

@prmukherj If we directly use StandaloneLauncher class + dry_run, will we able to run it in github?

yes, should be possible.

[Copilot]

Pull Request Overview

This PR adds a test case to verify that PyFluent launches with PyConsole enabled by default. The test ensures that the -py flag is included in the fluent launch string when using dry_run mode.

• Add a new standalone test function to verify default PyConsole behavior
• Include changelog entry documenting the new test

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File	Description
tests/test_launcher.py	Adds new test function to verify -py flag is present in default launch string
doc/changelog.d/4371.test.md	Documents the addition of the new test case

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

[Copilot]

Pull Request Overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}