Introduce 7.0 server version for 2024R1 #891
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PProfizi
reviewed
Apr 11, 2023
There was a problem hiding this comment.
Hi @guptadivya1501,
This will have to wait for the release of at least pydpf-core 0.8.1, plus the update to ansys-dpf-server-2024-1-pre0 on ansys-dpf/dpf-standalone repository.
anslpa
reviewed
Apr 11, 2023
PProfizi
requested changes
Apr 11, 2023
There was a problem hiding this comment.
you also need to change this line
https://github.com/pyansys/pydpf-core/blob/53236f8532f154242d078d5e653ebbad6aec1bee/pyproject.toml#L8
Codecov Report
@@ Coverage Diff @@
## master #891 +/- ##
==========================================
- Coverage 88.33% 88.23% -0.10%
==========================================
Files 73 73
Lines 8338 8331 -7
==========================================
- Hits 7365 7351 -14
- Misses 973 980 +7 |
anslpa
approved these changes
Apr 11, 2023
PProfizi
reviewed
May 9, 2023
PProfizi
reviewed
May 9, 2023
We may want to release pydpf-core with patch fixes before the actual 0.9.0 for 2024R1.pre0, so the best option is to keep it to 0.8.2.dev0, and only bump when required.
PProfizi
approved these changes
May 10, 2023
PProfizi
changed the title
anslpa
approved these changes
May 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.