Skip to content

Conversation

@rafacanton
Copy link
Contributor

Plotting methods are optimized by means of the mesh_to_pyvista operator

@rafacanton rafacanton added the enhancement New feature or request label Mar 30, 2023
@rafacanton rafacanton self-assigned this Mar 30, 2023
@codecov
Copy link

codecov bot commented Mar 30, 2023

Codecov Report

Merging #873 (09b04e5) into master (0094314) will increase coverage by 0.08%.
The diff coverage is 94.59%.

@@            Coverage Diff             @@
##           master     #873      +/-   ##
==========================================
+ Coverage   88.65%   88.74%   +0.08%     
==========================================
  Files          72       72              
  Lines        8226     8253      +27     
==========================================
+ Hits         7293     7324      +31     
+ Misses        933      929       -4     

@rafacanton
Copy link
Contributor Author

Tests are passing because for all server versions (both retro and current), the pyVista UnstructuredGrid is being generated at the except block. This PR should be merged after the dpf_standalone repo is updated with the server changes and then the tests and examples with the current version will use the new code

@rafacanton
Copy link
Contributor Author

rafacanton commented Apr 11, 2023

@PProfizi @anslpa This is ready to go (explicitly setting the server to run the operator as the same server of the mesh did the trick). The CodeCov is also in green (all the tests in the latest version are covering the new functionality). The new doc also looks good (top new, bottom old):
image
image

@PProfizi PProfizi self-requested a review April 11, 2023 12:52
@rafacanton rafacanton merged commit 568772f into master Apr 11, 2023
@rafacanton rafacanton deleted the rcanton/mesh_to_pyvista branch April 11, 2023 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants