Skip to content

Conversation

@ansys-akarcher
Copy link
Contributor

self.live was updated for LegacyGrpcServer but was not for GrpcServer.

This causes issues when shutting down and starting a new server immediately from the same variable.

Perhaps it may be better to add a mechanism upper in the class hierarchy in BaseServer so this variable gets updated for every child class ?

@codecov
Copy link

codecov bot commented Mar 23, 2023

Codecov Report

Merging #857 (4c28b5e) into master (e3e15c0) will decrease coverage by 0.28%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##           master     #857      +/-   ##
==========================================
- Coverage   88.79%   88.52%   -0.28%     
==========================================
  Files          72       72              
  Lines        8220     8226       +6     
==========================================
- Hits         7299     7282      -17     
- Misses        921      944      +23     

@cbellot000 cbellot000 requested a review from rlagha March 24, 2023 07:51
@cbellot000
Copy link
Contributor

@ansys-akarcher mayeb you could add the script you created to reproduce the bug as a unit test? they are in "/tests" folder

@ansys-akarcher ansys-akarcher merged commit 9783e80 into master Mar 29, 2023
@ansys-akarcher ansys-akarcher deleted the fix/grpcserver.shutdown branch March 29, 2023 09:58
@PProfizi PProfizi added the bug Something isn't working label Apr 3, 2023
@PProfizi PProfizi added this to the v0.8.0 milestone Apr 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants