Skip to content

Conversation

@PProfizi
Copy link
Contributor

@PProfizi PProfizi commented Feb 23, 2023

Translate coordinates to numpy array of type np.number in Line.init when not a DPF Field.
Fixes an error here https://github.com/pyansys/pydpf-core/actions/runs/4252250685/jobs/7395598740#step:11:2539
specific to Python 3.7 which still uses Numpy 1.21.6 (latest for 3.7).

@PProfizi PProfizi added the bug Something isn't working label Feb 23, 2023
@PProfizi PProfizi self-assigned this Feb 23, 2023
@PProfizi PProfizi requested a review from anslpa February 23, 2023 13:09
@PProfizi
Copy link
Contributor Author

PProfizi commented Feb 23, 2023

Test CI equivalent to a release context: https://github.com/pyansys/pydpf-core/actions/runs/4253099124

@codecov
Copy link

codecov bot commented Feb 23, 2023

Codecov Report

Merging #810 (517a110) into master (9447973) will decrease coverage by 4.78%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #810      +/-   ##
==========================================
- Coverage   87.42%   82.64%   -4.78%     
==========================================
  Files          72       72              
  Lines        8181     8182       +1     
==========================================
- Hits         7152     6762     -390     
- Misses       1029     1420     +391     

@anslpa anslpa self-requested a review February 23, 2023 13:27
@PProfizi PProfizi requested a review from cbellot000 February 23, 2023 13:29
@PProfizi PProfizi merged commit 898cf61 into master Feb 23, 2023
@PProfizi PProfizi deleted the fix/line_from_points_array branch February 23, 2023 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants