Improve plot method of the geometries #715
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #715 +/- ##
==========================================
+ Coverage 87.17% 88.62% +1.45%
==========================================
Files 71 71
Lines 8070 8081 +11
==========================================
+ Hits 7035 7162 +127
+ Misses 1035 919 -116 |
PProfizi
reviewed
Dec 21, 2022
PProfizi
approved these changes
Dec 21, 2022
Co-authored-by: PProfizi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #712.
This PR improves the plotting capabilities of the
.plot()method of the geometric objectsPoints,LineandPlane.Changes proposed:
geometry.py: accept optional argumentmeshso the user can plot the geometric object together with the 3D mesh from the model.plotter.py: accept**kwargsas arguments sopyvistaoptions are accepted.test_geometry.py: add test for plotting geometries together with the mesh.07-plot_on_geometries.py: improve example also showing how to plot the geometries together with the mesh.This PR still has to include the changes after #714 is merged.