Skip to content

Conversation

@Revathyvenugopal162
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Dec 19, 2022

Codecov Report

Merging #707 (5b4a953) into master (f5ded89) will decrease coverage by 0.04%.
The diff coverage is 87.55%.

@@            Coverage Diff             @@
##           master     #707      +/-   ##
==========================================
- Coverage   88.49%   88.44%   -0.05%     
==========================================
  Files          71       71              
  Lines        8091     8091              
==========================================
- Hits         7160     7156       -4     
- Misses        931      935       +4     

Copy link
Contributor

@GuillemBarroso GuillemBarroso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor changes. LGTM! Let's wait for @PProfizi review as well.

pyproject.toml Outdated
[project]
# Check https://flit.readthedocs.io/en/latest/pyproject_toml.html for all available sections
name = "ansys-dpf-core"
version = "0.7.dev0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@PProfizi, how should we define version here? This is following other pyansys repos convention, but I remember we talked about PyDPF-Core using 0.7.Z.dev0, right?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GuillemBarroso @Revathyvenugopal162 Indeed, the version should be 0.7.3.dev0 (we are releasing 0.7.2)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok i got your point. but usually we will not keep track of the patch releases, 0.7.dev0 or if we have already 0.7 release, then 0.8.dev0 is the usual way of keeping track, so that the patch release is not going to affect the dev version. https://peps.python.org/pep-0440/#developmental-releases. but no offence. ultimately the developers can decide .

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with either. I think it would be nice to be consistent with other repos and use 0.8.dev0, but I am not fully aware of the implications of changing this. @PProfizi, your call.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GuillemBarroso @Revathyvenugopal162 , this needs to be 0.7.3.dev0, which was for example set in #709

Copy link
Contributor

@PProfizi PProfizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am alright with what I saw in the pyproject.toml
Do you know why black went and edited all files again? A change with the new version?
Also we might want to publish on testPyPI to make sure the metadata is alright.

Revathyvenugopal162 and others added 2 commits December 20, 2022 12:42
Co-authored-by: Guillem Barroso <[email protected]>
Co-authored-by: PProfizi <[email protected]>
@Revathyvenugopal162 Revathyvenugopal162 marked this pull request as ready for review December 20, 2022 11:42
Co-authored-by: Guillem Barroso <[email protected]>
@Revathyvenugopal162
Copy link
Contributor Author

I am alright with what I saw in the pyproject.toml Do you know why black went and edited all files again? A change with the new version? Also we might want to publish on testPyPI to make sure the metadata is alright.

The default line length formatting for black is 80. but in flake 8 we specified to 100, so i changed to 100. And i think it is a good number.

Co-authored-by: PProfizi <[email protected]>
@GuillemBarroso
Copy link
Contributor

I am alright with what I saw in the pyproject.toml Do you know why black went and edited all files again? A change with the new version? Also we might want to publish on testPyPI to make sure the metadata is alright.

The default line length formatting for black is 80. but in flake 8 we specified to 100, so i changed to 100. And i think it is a good number.

Yep. I like 100.

@PProfizi PProfizi merged commit 7dba1d4 into master Jan 17, 2023
@PProfizi PProfizi deleted the Feat/migrate-to-toml branch January 17, 2023 08:25
@PProfizi PProfizi added the maintenance Repository structure maintenance label Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenance Repository structure maintenance

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants