Skip to content

Update README.md install command for development #607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 9, 2022
Merged

Update README.md install command for development #607

merged 1 commit into from
Nov 9, 2022

Conversation

@PProfizi
Copy link
Contributor

@PProfizi PProfizi commented Nov 8, 2022

No description provided.

@PProfizi PProfizi added the documentation Improvements or additions to documentation label Nov 8, 2022
@PProfizi PProfizi self-assigned this Nov 8, 2022
@codecov
Copy link

codecov bot commented Nov 8, 2022 •
edited
Loading

Codecov Report

Merging #607 (8a23434) into master (be8d22d) will decrease coverage by 1.85%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #607      +/-   ##
==========================================
- Coverage   87.90%   86.05%   -1.86%     
==========================================
  Files          68       68              
  Lines        7566     7566              
==========================================
- Hits         6651     6511     -140     
- Misses        915     1055     +140

GuillemBarroso
GuillemBarroso approved these changes Nov 8, 2022
View reviewed changes
Copy link
Contributor

@GuillemBarroso GuillemBarroso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have seen in other repos that the README is included as the first page of the documentation. Maybe we could also do this here? So we avoid to have "duplicated" documentation?

@PProfizi
Copy link
Contributor Author

PProfizi commented Nov 9, 2022

I have seen in other repos that the README is included as the first page of the documentation. Maybe we could also do this here? So we avoid to have "duplicated" documentation?

Right now the two do not have the same structure. We might do this in the future but this is not a priority right now.

@PProfizi PProfizi merged commit 0b40142 into master Nov 9, 2022
@PProfizi PProfizi deleted the doc/update_readme_dev_install_command branch November 9, 2022 09:02
@GuillemBarroso GuillemBarroso mentioned this pull request Nov 14, 2022
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@GuillemBarroso GuillemBarroso GuillemBarroso approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@PProfizi PProfizi

Labels

documentation Improvements or additions to documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@PProfizi @GuillemBarroso