Skip to content

Fix testing on Docker for Windows #598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Nov 9, 2022
Merged

Fix testing on Docker for Windows #598

merged 6 commits into from
Nov 9, 2022

Conversation

@cbellot000
Copy link
Contributor

@cbellot000 cbellot000 commented Nov 4, 2022 •
edited
Loading

Fix testing and server to run on windows docker

@cbellot000 cbellot000 marked this pull request as ready for review November 4, 2022 10:06
@cbellot000 cbellot000 requested review from PProfizi and anslpa November 4, 2022 10:06
@codecov
Copy link

codecov bot commented Nov 4, 2022 •
edited
Loading

Codecov Report

Merging #598 (e88a58e) into master (be8d22d) will increase coverage by 0.09%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##           master     #598      +/-   ##
==========================================
+ Coverage   87.90%   87.99%   +0.09%     
==========================================
  Files          68       68              
  Lines        7566     7566              
==========================================
+ Hits         6651     6658       +7     
+ Misses        915      908       -7

PProfizi
PProfizi approved these changes Nov 4, 2022
View reviewed changes
Copy link
Contributor

@PProfizi PProfizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cbellot000 Do you plan to use the "slow" mark somewhere?

PProfizi
PProfizi reviewed Nov 4, 2022
View reviewed changes
@cbellot000
Copy link
Contributor Author

@cbellot000 Do you plan to use the "slow" mark somewhere?

@PProfizi I used in our tfs pipelines

@cbellot000 cbellot000 merged commit 91fafd8 into master Nov 9, 2022
@cbellot000 cbellot000 deleted the testing/run_on_docker_windows branch November 9, 2022 09:16
@PProfizi PProfizi added the CI/CD Related to CI/CD label Nov 25, 2022
@PProfizi PProfizi changed the title Testing/run on docker windows Add testing on Docker Windows Nov 25, 2022
@PProfizi PProfizi changed the title Add testing on Docker Windows Fix testing on Docker for Windows Nov 25, 2022
@PProfizi PProfizi mentioned this pull request May 25, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PProfizi PProfizi PProfizi approved these changes

+1 more reviewer

@anslpa anslpa anslpa approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

CI/CD Related to CI/CD

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@cbellot000 @anslpa @PProfizi