Skip to content

Conversation

@kmahajan-cadfem
Copy link
Contributor

  • fixed element_ids, previously it was only 1 for all elements
  • changed naming from id -> n_id and e_id

- fixed element_ids, previously it was only 1 for all elements
- changed naming from id -> n_id and e_id
@PProfizi
Copy link
Contributor

PProfizi commented Oct 11, 2022

Hello @kmahajan-cadfem, thank you for your contribution!
Due to GitHub's policy on secrets, validation workflows run for PRs from forked repositories will not work for this project.
One solution [edit: if you have write access] to contribute is to clone the repository instead of forking it (despite forking being the best practice, as mentioned in our case it cannot work). Another is for me to replicate your proposed changes in a PR of my own.
As you prefer!

@kmahajan-cadfem
Copy link
Contributor Author

@PProfizi,
Do you mean clone, create branch and then push?
I have already tried this but could not create new remote branch!!

@PProfizi
Copy link
Contributor

@kmahajan-cadfem, you are right, sorry, since write access are limited, not everyone can do that.
If you plan on contributing often I can check whether we could give you write access. If not, I will also ask the organization owners about the possibility to create a custom role that would make your contribution possible.
In the meantime I will simply prepare a PR with your suggestions and ping you.
Sorry about the confusion.

@kmahajan-cadfem
Copy link
Contributor Author

@PProfizi
for this change it does not make much sense to give me access, and you can go ahead.
as for the question, if i will be contributing regularly or not, I can not really answer you clearly because I also have other things to take care of and this is just by chance that I looked at the code and saw that there are some changes necessary.

I am still interested to know what are the options for DEVs(customers) to contribute?

@PProfizi
Copy link
Contributor

@PProfizi for this change it does not make much sense to give me access, and you can go ahead. as for the question, if i will be contributing regularly or not, I can not really answer you clearly because I also have other things to take care of and this is just by chance that I looked at the code and saw that there are some changes necessary.

I am still interested to know what are the options for DEVs(customers) to contribute?

Hi @kmahajan-cadfem well the options to contribute are :

  • to be registered as contributor with write access.
  • to open an enhancement issue with a description of the changes to be made, including possibly doing like you did wiith a PR from a fork as even though it will not get merged, one could still cherry-pick the commits on your fork branch to prepare an identical PR directly on the original repository.

@PProfizi
Copy link
Contributor

PProfizi commented Oct 13, 2022

For future reference, the twin PR for checks is #550.
Approving as all checks pass.

@PProfizi PProfizi closed this Oct 13, 2022
@PProfizi PProfizi reopened this Oct 13, 2022
@PProfizi
Copy link
Contributor

Hi @kmahajan-cadfem, small change of plans. After discussing with colleagues managing the pyansys organisation, the conclusion was that to better give credit to external contributors, the process would be to create a mirror PR, run the checks there, then merge your PR by bypassing the required checks. This way we better keep track of contributors and give credit where due.
Again, sorry for the fuss, we are still settling the process concerning external contributions.

@PProfizi PProfizi changed the title fixed element ids for creation of elements in example Fix 03-create_entities example Oct 13, 2022
@PProfizi PProfizi enabled auto-merge (squash) October 13, 2022 15:24
@PProfizi PProfizi disabled auto-merge October 13, 2022 15:25
@PProfizi PProfizi merged commit 2d931ff into ansys:master Oct 13, 2022
@kmahajan-cadfem kmahajan-cadfem deleted the bug/example_element_ids_not_incremented branch October 17, 2022 10:48
@PProfizi PProfizi added bug Something isn't working documentation Improvements or additions to documentation and removed bug Something isn't working labels Oct 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants