Update MeshedRegion.grid coordinates when necessary and clear data before plotting. #513

PProfizi · 2022-09-27T15:40:03Z

to allow for plotting of modified meshes with mesh setters.

Use case:

import numpy as np
from ansys.dpf import core as dpf
from ansys.dpf.core import examples

model = dpf.Model(examples.simple_bar)
ncoord_f = model.metadata.meshed_region.nodes.coordinates_field
model.metadata.meshed_region.plot()

my_field_rotation_matrix = dpf.fields_factory.create_scalar_field(1)
my_field_rotation_matrix.data = np.array([[1],[0],[0],[0],[0],[1],[0],[-1],[0]])

op = dpf.operators.geo.rotate()
op.inputs.field.connect(ncoord_f)
op.inputs.field_rotation_matrix.connect(my_field_rotation_matrix)

op = dpf.operators.geo.rotate(field=ncoord_f, field_rotation_matrix=my_field_rotation_matrix)

result_field = op.outputs.field()

mesh = model.metadata.meshed_region
mesh.nodes.coordinates_field = result_field
mesh.plot()

Update the vtk grid associated to the mesh when the coordinates are modified via set_coordinates_field or set_property_field(coordinates) (and by extension via nodes.coordinates). -> this uses the pyvista.UnstructuredGrid.points setter.
Update the vtk grid associated to the mesh when the connectivity is modified via set_property_field( nodal_properties.nodal_connectivity or element_properties.connectivity). -> there is no setter for pyvista.UnstructuredGrid.cells or pyvista.UnstructuredGrid.cell_connectivity, so the only solution seems to invalidate the grid. This requires more work, yet to solve the current reported bugs this is not necessary as they only concern updating the coordinates.
Also reset the grid's data using grid.clear_data() when using Plotter.plot_contour or DpfPlotter.add_mesh.

…meshes with mesh setters.

codecov · 2022-09-27T15:52:05Z

Codecov Report

Merging #513 (fed2f19) into master (e17deae) will increase coverage by 0.16%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #513      +/-   ##
==========================================
+ Coverage   86.79%   86.96%   +0.16%     
==========================================
  Files          67       67              
  Lines        7196     7212      +16     
==========================================
+ Hits         6246     6272      +26     
+ Misses        950      940      -10

…odified meshes with mesh setters." This reverts commit b39d904.

…ordinates_field.

…ot_contour.

rlagha · 2022-09-30T16:09:58Z

ansys/dpf/core/meshed_region.py

        coordinates_field : PropertyField or Field
        """
        self._api.meshed_region_set_coordinates_field(self, coordinates_field)
+        self._full_grid = None


can't we just invalidate the coords of the grid?

@rlagha FYI I modified the proposed code as requested.

…lidating the whole UnstructuredGrid.

cbellot000 · 2022-10-05T07:17:46Z

ansys/dpf/core/meshed_region.py

        coordinates_field : PropertyField or Field
        """
        self._api.meshed_region_set_coordinates_field(self, coordinates_field)
+        if self._full_grid is not None:


@PProfizi In my opinion, we need to think larger. Here the "real" issue is not "when set coordinates is called the grid needs to be updated" but "when the mesh is updated (equivalent to setters are called) the grid is out dated".
With your we will have the same bug if set connectivity, or set element types is called

cbellot000 · 2022-10-05T07:20:21Z

ansys/dpf/core/plotter.py

        >>> pl.add_mesh(mesh)

        """
+        if meshed_region.grid is not None:


Have you checked what happens with meshes containers?

ansys/dpf/core/meshed_region.py

…roperty_field of connectivity to check update of the mesh.grid.

…linked to the mesh.

…ch example.

This reverts commit 89d4f75.

This reverts commit 23c5ece.

This reverts commit ce9d569.

This reverts commit 6f5e080.

* Move Documentation to a reusable workflow, can be manually triggered or called by the CI. * Move tests to tests.yml, can be triggered manually, can be called by the CI. * Add gate.yml workflow for gatebin testing. * Install ansys-grpc-dpf==0.4.0 when ANSYS_VERSION=221 * Add wheel and wheelhouse arguments to the tests.yml * Set wheel and wheelhouse arguments as optional. * Create a reusable workflow for running examples, which can be triggered manually or called from the CI. * Set optional arguments as optional * Update docs workflow to the latest master changes * Call docs from CI * Update tests.yml to reflect changes in master * Add "extra" env * Update examples.yml to latest in master * call examples.yml in CI * Update retro jobs in CI * Add debug job in CI * Add gate job in CI * Update gate.yml * Update name of docs workflow in ci.yml * Update needs of draft_release * Update tests.yml add DOCSTRING argument * Use lower-case names * Fix docs.yml * Rename testing step in tests.yml * Update tests.yml to current master state. * Update gate.yml to current master state. * Update docs.yml to current master state. * Skip running python-operators examples when on linux. * Apply changes from #537 to doc job * Apply changes from #513 to doc job * Do not automatically run CI on push to release* branch. This can be managed via a PR if necessary. In theory one can push a bump commit and a tag, which requires only the CI on the tag push. * Add docs_on_release step, add 3.8 to release steps. * Separate the workflow triggered on v* tag push. * Schedule CI release every sunday at 1pm UTC. Condition draft_release step to push of tag. * Fix pydpf-post_testing workflow branch name issue * Allow for workflow call of PyDPF-Post testing * Run PyDPF-Post compatibility testing on both windows and linux * Run PyDPF-Post compatibility testing on latest tagged revision by default * PyDPF-Post compatibility testing accepts ANSYS_VERSION as input * Run PyDPF-Post compatibility testing on non-draft CI * Run PyDPF-Post compatibility testing on release and weekly CI for 231, 222 and 221 * PyDPF-Post branch name is not required * Fix PyDPF-Post cloning step * Make pydpf-post testing necessary for draft_release in ci_release.yml * Remove concurrency temporarily * Add back concurrency * Comment other jobs temporarily * Add pydpf-post-TOKEN as required input when run from a workflow * Split repo name construction * Actually no need for the dpf-post secret * Fix pydpf-post cloning step. * Fix pydpf-post cloning step. * Fix pydpf-post install step. * Fix pydpf-post install step. * Fix pydpf-post install step. * Fix pydpf-post install step. * Use new "working-directory" input for prepare_tests and test_docstrings actions. * Fix test API * Use prepare_v2.2 pydpf-actions * Uncomment all jobs * Fix pydpf-post.yml * Fix pydpf-post.yml - test docstrings in src/ * Quick fix: only use the three first parts of version strings. * Update deprecated set-output command. * Fix test-results-post log path * Use packaging.version.parse instead of our custom version_tuple function. * Fix setup step * Fix setup step * Remove test_version_tuple * Bump all pydpf-actions to v2.2 * Merge with master, apply changes for test_docker * Test test_docker on a regular PR

Remove the MeshedRegion.grid cache to allow for plotting of modified …

b39d904

…meshes with mesh setters.

PProfizi self-assigned this Sep 27, 2022

PProfizi added 2 commits September 27, 2022 18:25

Revert "Remove the MeshedRegion.grid cache to allow for plotting of m…

55bbd9f

…odified meshes with mesh setters." This reverts commit b39d904.

Rather than removing the cache, reset the grid after a call to set_co…

5e05ecd

…ordinates_field.

PProfizi changed the title ~~Remove the MeshedRegion.grid cache~~ Reset MeshedRegion.grid when coordinates are updated. Sep 27, 2022

Upload the doc even if failed, to be able to check on it.

52afa44

PProfizi marked this pull request as ready for review September 28, 2022 15:45

PProfizi added the bug Something isn't working label Sep 28, 2022

PProfizi requested a review from cbellot000 September 28, 2022 16:02

Add grid.clear_data() to DpfPlotter.add_mesh as well as to Plotter.pl…

f6c89cc

…ot_contour.

PProfizi changed the title ~~Reset MeshedRegion.grid when coordinates are updated.~~ Reset MeshedRegion.grid when necessary. Sep 30, 2022

PProfizi changed the title ~~Reset MeshedRegion.grid when necessary.~~ Reset MeshedRegion.grid or its clear its data when necessary. Sep 30, 2022

rlagha reviewed Sep 30, 2022

View reviewed changes

rlagha requested a review from pthieffry October 3, 2022 08:42

PProfizi added 4 commits October 3, 2022 11:07

Update the grid.points when setting coordinates field instead of inva…

d057409

…lidating the whole UnstructuredGrid.

Update the grid.points when setting coordinates field instead of inva…

10358ca

…lidating the whole UnstructuredGrid.

Improve coverage.

792ab30

Improve coverage and fix data copy.

03d3ba7

PProfizi requested a review from rlagha October 3, 2022 14:56

PProfizi changed the title ~~Reset MeshedRegion.grid or its clear its data when necessary.~~ Reset MeshedRegion.grid or clear its data when necessary. Oct 4, 2022

cbellot000 reviewed Oct 5, 2022

View reviewed changes

Decorate setters to invalidate the grid entirely.

e27416c

PProfizi commented Oct 6, 2022

View reviewed changes

ansys/dpf/core/meshed_region.py Outdated Show resolved Hide resolved

PProfizi added 6 commits October 7, 2022 10:38

Add an actual clean command.

f8a3514

Add an actual clean command.

5651022

Set default language as "en" in conf.py to remove warning.

59a7ec7

Fix 08.averaging\README.txt

a399da9

Fix indent

a748683

Fix indent

f122405

PProfizi added 7 commits October 10, 2022 16:21

Comment 03-exchange_data_between_servers.py

23c5ece

Comment 11-server_types.py

89d4f75

Add a waiting time for servers to close.

7a8935b

Adjust MeshedRegion's setter tests for set_coordinate_field and set_p…

a889e3b

…roperty_field of connectivity to check update of the mesh.grid.

Proposal for a wrapper which deals with updating the vtk grid object …

d380be3

…linked to the mesh.

Fix flake8

2c3414b

Rescope to the issue at end: update the coordinates.

ed41364

PProfizi linked an issue Oct 11, 2022 that may be closed by this pull request

legend overlay with multiple plots in jupyter notebook #367

Closed

3 tasks

PProfizi removed a link to an issue Oct 11, 2022

legend overlay with multiple plots in jupyter notebook #367

Closed

3 tasks

PProfizi added 12 commits October 11, 2022 17:56

Fix flake8

141693d

Merge branch 'master' into fix/remove_grid_cache

0f2ab19

Merge branch 'master' into fix/doc_generation_2

3358caf

Add garbage collection and call shutdown_all_session_servers after ea…

62999b4

…ch example.

Revert "Comment 11-server_types.py"

0c5a2e1

This reverts commit 89d4f75.

Revert "Comment 03-exchange_data_between_servers.py"

4d7e2ba

This reverts commit 23c5ece.

Shut servers down and collect garbage before the examples too.

78b20ba

Merge branch 'master' into fix/doc_generation_2

f686012

Revert "Comment-out other jobs"

c037168

This reverts commit ce9d569.

Revert "Comment-out other jobs"

6087460

This reverts commit 6f5e080.

Merge branch 'master' into fix/remove_grid_cache

7d647c8

Merge branch 'fix/doc_generation_2' into fix/remove_grid_cache

9199890

PProfizi requested a review from cbellot000 October 12, 2022 13:38

cbellot000 approved these changes Oct 14, 2022

View reviewed changes

Merge branch 'master' into fix/remove_grid_cache

fed2f19

PProfizi changed the title ~~Reset MeshedRegion.grid or clear its data when necessary.~~ Update MeshedRegion.grid coordinates upon use of MeshedRegion.set_coordinates() Oct 14, 2022

PProfizi changed the title ~~Update MeshedRegion.grid coordinates upon use of MeshedRegion.set_coordinates()~~ Update MeshedRegion.grid coordinates when necessary and clear data before plotting. Oct 14, 2022

PProfizi merged commit f5b7a85 into master Oct 14, 2022

PProfizi deleted the fix/remove_grid_cache branch October 14, 2022 10:45

PProfizi added a commit that referenced this pull request Oct 20, 2022

Apply changes from #513 to doc job

320fe4e

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Update MeshedRegion.grid coordinates when necessary and clear data before plotting. #513

Update MeshedRegion.grid coordinates when necessary and clear data before plotting. #513

Uh oh!

PProfizi commented Sep 27, 2022 •

edited

Loading

Uh oh!

codecov bot commented Sep 27, 2022 •

edited

Loading

Uh oh!

rlagha Sep 30, 2022

Uh oh!

PProfizi Oct 3, 2022

Uh oh!

cbellot000 Oct 5, 2022

Uh oh!

cbellot000 Oct 5, 2022

Uh oh!

PProfizi Oct 6, 2022

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Update MeshedRegion.grid coordinates when necessary and clear data before plotting. #513

Update MeshedRegion.grid coordinates when necessary and clear data before plotting. #513

Uh oh!

Conversation

PProfizi commented Sep 27, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented Sep 27, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

rlagha Sep 30, 2022

Choose a reason for hiding this comment

Uh oh!

PProfizi Oct 3, 2022

Choose a reason for hiding this comment

Uh oh!

cbellot000 Oct 5, 2022

Choose a reason for hiding this comment

Uh oh!

cbellot000 Oct 5, 2022

Choose a reason for hiding this comment

Uh oh!

PProfizi Oct 6, 2022

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

PProfizi commented Sep 27, 2022 •

edited

Loading

codecov bot commented Sep 27, 2022 •

edited

Loading